-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add qualifier injection tests for Annotation defined resources #416
Conversation
8e75f45
to
53cc348
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing these. I added a few suggestions about minor things. Some of the assertions look like they have expected/actual reversed. I checked here https://junit.org/junit5/docs/5.9.1/api/org.junit.jupiter.api/org/junit/jupiter/api/Assertions.html#assertEquals(java.lang.Object,java.lang.Object) which seemed to confirm what I thought the ordering should be. In either case, the tests will still give the correct results, but failure messages about the expected and actual values would be misleading.
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/dd/DeploymentDescriptorServlet.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/dd/DeploymentDescriptorServlet.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/dd/DeploymentDescriptorServlet.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/dd/DeploymentDescriptorServlet.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/anno/AnnotationTestBean.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/anno/AnnotationTestBean.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/anno/AnnotationTestBean.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/anno/AnnotationTestBean.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/anno/AnnotationServlet.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/anno/AnnotationServlet.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/anno/AnnotationServlet.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/anno/AnnotationServlet.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/anno/AnnotationServlet.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/anno/AnnotationServlet.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/anno/AnnotationServlet.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/dd/DeploymentDescriptorServlet.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/dd/DeploymentDescriptorTestBean.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/concurrent/spec/Platform/dd/DeploymentDescriptorTestBean.java
Outdated
Show resolved
Hide resolved
aedd310
to
45e4065
Compare
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
45e4065
to
5455dd3
Compare
More tests for #404