Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualifier injection tests for Annotation defined resources #416

Merged
merged 5 commits into from Jan 29, 2024

Conversation

KyleAure
Copy link
Contributor

More tests for #404

@KyleAure KyleAure self-assigned this Jan 19, 2024
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing these. I added a few suggestions about minor things. Some of the assertions look like they have expected/actual reversed. I checked here https://junit.org/junit5/docs/5.9.1/api/org.junit.jupiter.api/org/junit/jupiter/api/Assertions.html#assertEquals(java.lang.Object,java.lang.Object) which seemed to confirm what I thought the ordering should be. In either case, the tests will still give the correct results, but failure messages about the expected and actual values would be misleading.

@njr-11 njr-11 added the TCK label Jan 19, 2024
@njr-11 njr-11 added this to the 3.1 milestone Jan 19, 2024
KyleAure and others added 2 commits January 23, 2024 11:14
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
@KyleAure KyleAure force-pushed the 404-qualifier-anno-tests branch 2 times, most recently from aedd310 to 45e4065 Compare January 24, 2024 16:55
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
@KyleAure KyleAure merged commit beeb79a into jakartaee:main Jan 29, 2024
3 checks passed
@KyleAure KyleAure deleted the 404-qualifier-anno-tests branch January 29, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants