Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help automate specification project release review #477

Merged
merged 3 commits into from
May 2, 2024

Conversation

KyleAure
Copy link
Contributor

@KyleAure KyleAure commented Apr 19, 2024

Gathers all materials needed for specification project release review and packages them

@KyleAure KyleAure requested a review from mswatosh April 19, 2024 19:42
@KyleAure KyleAure self-assigned this Apr 19, 2024
@@ -161,7 +167,7 @@
<description>Jakarta Concurrency API documentation</description>
<doctitle>Jakarta Concurrency API documentation</doctitle>
<windowtitle>Jakarta Concurrency API documentation</windowtitle>
<header><![CDATA[<br>Jakarta Concurrency API v${project.version}]]></header>
<header><![CDATA[<br>Jakarta Concurrency API v${spec.specification.version}]]></header>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be spec.version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be either. The plugin before this does some verification between spec/project versions and spits out a set of properties that can be used elsewhere in the pom.xml. So I used the verified value here.

api/README.md Outdated Show resolved Hide resolved
api/README.md Outdated Show resolved Hide resolved
@KyleAure
Copy link
Contributor Author

Ready to merge once 3.1.0 is published (don't want to introduce changes to the spec pom if we need to do a rebuild)

@KyleAure KyleAure merged commit 48c58b5 into jakartaee:main May 2, 2024
3 checks passed
@KyleAure KyleAure deleted the fix-spec-generation branch May 2, 2024 14:36
@KyleAure KyleAure mentioned this pull request May 2, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants