Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address signature test issues from issue 681 #682

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

starksm64
Copy link
Contributor

fixes #681

fixes jakartaee#681

Signed-off-by: Scott M Stark <starksm64@gmail.com>
Copy link
Contributor

@KyleAure KyleAure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the deployment to package the new signature test plugin.

File sigTestDep = Maven.resolver().resolve("org.netbeans.tools:sigtest-maven-plugin:1.6").withoutTransitivity().asSingleFile();

@starksm64 I can open a different PR to do this work, or if you are able to test core profile you can update this PR. Let me know.

Signed-off-by: Scott M Stark <starksm64@gmail.com>
@starksm64
Copy link
Contributor Author

We also need to update the deployment to package the new signature test plugin.

File sigTestDep = Maven.resolver().resolve("org.netbeans.tools:sigtest-maven-plugin:1.6").withoutTransitivity().asSingleFile();

@starksm64 I can open a different PR to do this work, or if you are able to test core profile you can update this PR. Let me know.

I add that change in the last commit

@starksm64 starksm64 requested a review from KyleAure April 10, 2024 21:28
Copy link
Contributor

@KyleAure KyleAure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally and everything is working now. Thanks @starksm64

@KyleAure KyleAure merged commit 1dd76cd into jakartaee:main Apr 11, 2024
3 checks passed
@gavinking
Copy link
Contributor

I think this broke the build, maybe because we still have stuff like <sigtest.version>1.6</sigtest.version> in some places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SignatureTest issues
3 participants