Skip to content

Commit

Permalink
Further fix for #157. Expand use of generics in API.
Browse files Browse the repository at this point in the history
  • Loading branch information
markt-asf committed Jul 7, 2021
1 parent 2a2fa59 commit a14b203
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
6 changes: 4 additions & 2 deletions api/src/main/java/jakarta/el/ELProcessor.java
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,10 @@ public ELManager getELManager() {
* @param expression The Jakarta Expression Language expression to be evaluated.
* @return The result of the expression evaluation.
*/
public Object eval(String expression) {
return getValue(expression, Object.class);
public <T> T eval(String expression) {
@SuppressWarnings("unchecked")
T result = (T) getValue(expression, Object.class);
return result;
}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/glassfish/el/test/ELProcessorTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ public void testSetVariable () {
elp.setVariable("xx", null);
assertEquals(elp.eval("xx"), null);
elp.setVariable("yy", "abc");
assertEquals(elp.eval("yy = 123; abc"), 123L);
assertEquals(elp.eval("abc = 456; yy"), 456L);
assertEquals(elp.eval("yy = 123; abc"), Long.valueOf(123));
assertEquals(elp.eval("abc = 456; yy"), Long.valueOf(456));
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/glassfish/el/test/StaticRefTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,6 @@ public void testConstructor() {

@Test
public void testStaticMethod() {
assertEquals(4, elp.eval("Integer.numberOfTrailingZeros(16)"));
assertEquals(Long.valueOf(4), elp.eval("Integer.numberOfTrailingZeros(16)"));
}
}

0 comments on commit a14b203

Please sign in to comment.