Add rowStatePreserved property to UIRepeat, exactly the same as UIData

[eclipse-faces-bot]

This is the implementation work for #1230, but it can be done outside of the spec because properties can be added to Facelet backed components without having to change the TLD.

[eclipse-faces-bot]

@glassfishrobot Commented
Reported by @edburns

[eclipse-faces-bot]

@glassfishrobot Commented
Issue-Links:
blocks
JAVASERVERFACES-2633
is related to
JAVASERVERFACES_SPEC_PUBLIC-1230

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.

[eclipse-faces-bot]

@glassfishrobot Commented
@manfredriem said:
Setting priority to Major

[eclipse-faces-bot]

@glassfishrobot Commented
This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-1263

[eclipse-faces-bot]

• Issue Imported From: Add rowStatePreserved property to com.sun.faces.facelets.component.UIRepeat, exactly the same as javax.faces.component.UIData javaee/javaserverfaces-spec#1263
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: Unassigned

[tandraschko]

@arjantijms @BalusC WDYT about this? im currently working on a PF bug: primefaces/primefaces#10047

the problem is that ui:repeat doesnt have rowStatePreserved like UIData
its import to have this for such bugs

[tandraschko]

@BalusC are you ok with this? would like to start adding it to MF then

[BalusC]

Sure.

I however still want to extract a base class based on common logic of UIData and UIRepeat (UIIterable?) so we don't need to copy paste logic and it's also useful for e.g. PrimeFaces DataTable/Repeat, but I imagine this is a bit more of work.

[tandraschko]

yep, a base class would be the best
should we target that for 5.0? then we can create a new issue for this

i will start right now to add rowStatePreserved to ui:repeat in MF

[BalusC]

+1

This has been requested before as UIIterate: #963

Similar request but then for a tree component: #965

[tandraschko]

@BalusC
can we add rowStatePreserved in 4.1 and create something like UIIterate in 5.0?

[tandraschko]

added rowStatePreserved to ui:repeat for now

[BalusC]

Do you have a link to MF commit for reference?

[tandraschko]

apache/myfaces@16a2cf1

[volosied]

I had reused a lot of methods from our UIData class, so it would be good to create a superclass to avoid duplication in 5.0.

[BalusC]

We should indeed really look at some common superclass and preferably also move UIRepeat into the jakarta.faces.component API as earlier suggested by @mnriem .

As to the concrete issue, this can also be solved/workarounded by simply using c:forEach instead of ui:repeat. This is less trivial for h:dataTable (you'd need to write all the HTML table markup yourself), hence the rowStatePreserved makes more sense over there in h:dataTable.

[BalusC]

eclipse-ee4j/mojarra#2247 contains a useful use case / reproducer that could be used as tck.

[tandraschko]

yeah sure
i think the new attr is ok for 4.1 but in 5.0 we should make a superclass for it!