Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the facelettaglibrary to web-facelettaglibrary_4_0.xsd #1497

Merged
merged 0 commits into from Aug 25, 2022

Conversation

starksm64
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jun 28, 2022

Deploy Preview for jakartaee ready!

Name Link
🔨 Latest commit ccab423
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee/deploys/62ba86d4603f690009d3d3a7
😎 Deploy Preview https://deploy-preview-1497--jakartaee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pzygielo
Copy link
Contributor

pzygielo commented Jun 28, 2022

For me this shows:

  • source repo is missing web-facelettaglibrary_4_0.xsd, perhaps its rename from 3.0 to 4.0 was missed in Update Common shareable schemas from 9 to 10 jakartaee-schemas#15
    IMO this should be fixed in upstream first.
  • this repo - currently published web-facelettaglibrary for JakartaEE 9 references <xsd:include schemaLocation="jakartaee_10.xsd"/> which does not seem to be right and should be reverted to 9. Just to clarify - all changes to w-ftl-3.xsd should be reverted, not the single include only.

Similar to above - missing in jakartaee-schemas, JakartaEE 9 schema including Jakarta EE 10 - for https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_4_0.xsd and https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd accordingly.

@starksm64
Copy link
Contributor Author

I fixed the ee10 ref to ee9 in the 3_0 facelettaglibrary, but I don't understand the point of the jakartaee-schemas when it has only ever contained a fraction of the schemas, and cannot be the true source since the specification projects are what generate the schemas. I'll bring this up on tomorrows platform call.

@pzygielo
Copy link
Contributor

I fixed the ee10 ref to ee9 in the 3_0 facelettaglibrary,

The commit ccab423 brings some changes, but that's not what I meant:

Just to clarify - all changes to w-ftl-3.xsd should be reverted, not the single include only.

but I don't understand the point of the jakartaee-schemas when it has only ever contained a fraction of the schemas, and cannot be the true source since the specification projects are what generate the schemas.

I see. So what is the source of file committed here then? I can't locate it in the tree https://github.com/jakartaee/faces/tree/4.0.1-RELEASE. It's not a part of https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/faces/jakarta.faces-api/4.0.1 artifact. But I might be wrong assuming it's Faces responsinble for that schema.

When the spec generates the schema - what happens next, where does it go? I also wonder what's the point of jakartaee-schemas if it's not to be used for that.

@yersan
Copy link

yersan commented Jun 28, 2022

@starksm64 What about jakartaee_web_services_2_0.xsd?

This XSD version is used for Jakarta EE 9 and Jakarta EE 10. However, it was updated to use the Jakarta EE 10 common types.

Would it be safe from the point of view of Jakarta EE 9 descriptor validations? They will be using the Jakarta EE 10 common types instead of the Jakarta EE 9.

@pzygielo
Copy link
Contributor

😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants