New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta 9 release page #920 #929
Jakarta 9 release page #920 #929
Conversation
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Deploy preview for jakartaee ready! Built with commit 993a7e0 |
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, if we are using static/images/release-download-9-bg.jpg, we should shrink it, otherwise remove it
layouts/release/section.html
Outdated
<div class="jumbotron featured-jumbotron featured-jumbotron-download vertical-align flex-column margin-bottom-0"> | ||
|
||
<div class="flex-grow vertical-align-space-evenly flex-wrap"> | ||
<div class="col-md-10 flex-column"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By applying flex-grow: 1;
when only big screen view seems better, and also removed the space-between it removes the unnecessary space on mobile /tablet view
<div class="white-paper-bg"> | ||
<div class="col-lg-12 col-md-16 col-sm-24 col-lg-offset-3 col-md-offset-4 col-sm-offset-4 col-xs-offset-2 white-paper-download"> | ||
<p class="text-white vcenter"><img width="120" alt="white-paper-icon" class="icon" src="images/release-9/icon5.svg"></p> | ||
<h2 class="fw-600 vcenter text-blue"><strong>NEW TECHNICAL<br>WHITE PAPER</strong></h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the screen size for this?
This does have an issue that if zoom in or out, or change screen size the words comes out of the yellow image. That's why we change the text to blue.
Or I can try to adjust in different screen sizes, keep the words inside the yellow block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some adjustments and use a yellow block in the mobile view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to switch to request changes, oops
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
@karenmcnaughton @TanjaObradovic can you please confirm that the content is good and that all the links are correct? We believe that the Download Now and Watch the video interview links are currently incorrect. We are waiting for your +1 to push this on the website. |
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
@flora8984461 I just spoke with @karenmcnaughton and we would like to make the following changes before we can merge this:
|
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Did the change and waiting for the preview to be built. |
@karenmcnaughton I think we need to add the release date in the header to let people know this is not live but coming up soon. How about adding this below Previous Releases: Jakarta EE 8: Jakarta EE 9 is coming on December 8 ^We would then want to remove that text on December 8. |
@chrisguindon that works--thank you! |
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, some of the images are bigger than 100kb... is it possible to shrink them without lowering too much the quality?
less/release-9.less
Outdated
@@ -0,0 +1,351 @@ | |||
.flex-wrap { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be added to solstice-assets:
https://github.com/EclipseFdn/solstice-assets/blob/master/less/_components/classes-grid.less
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, will submit a patch for it.
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
static/images/jakarta9-image.png is very big, but I have tried some online tools, not quite successful to compress, wondering if you guys or the marketing team can have a better way to compress it? |
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Christopher Guindon <chris.guindon@eclipse-foundation.org>
@chrisguindon pls change the text Previous Releases: Jakarta EE 8 to Previous Release -- [drop the plural]--thanks! |
Fix #920
Tasks:
--------New tasks on Nov 6----------------
Change the url to release/9/
Add a link after the two buttons go to older release (8)
-------------- Finished tasks ------------------
Make the header
Need to make the header better on mobile
Make the section "FEATURES AND BENEFITS"
Make the section "COMMUNITY-POWERED INNOVATION" --- this need some more info on committers
it's done here : Contributor card list #923
Make the section "NEW TECHNICAL WHITE PAPER"
Make the section "LET’S GET SOCIAL"
Make the footer (Decide to remove the footer logo and keep the style)
Use the font
Adjust more on spacing, size, etc.
Need the icon images
Change header background (Want to use a video?)
Modify the footer template in https://github.com/EclipseFdn/hugo-solstice-theme so that we do not need to define it in the section.html (add params to custom footer class name and navbar logo EclipseFdn/hugo-solstice-theme#179)
After (add params to custom footer class name and navbar logo EclipseFdn/hugo-solstice-theme#179) merged, remove the {{ define "navbar" }} and {{ define "footer" }}
Signed-off-by: Yi Liu yi.liu@eclipse-foundation.org
------------------- We choose this one ---------------------------------------------------
In #926 , I use a separate image for the boat logo to overlap on the bg,
In this comparison, I use a combined bg img.
The main point is not the opacity, it's more about how will it show better on responsive and zoom in and out.🤔
How they are reflecting when zoom and on mobile is a little different,
And I need your suggestions on how I can improve this section.
Signed-off-by: Yi Liu yi.liu@eclipse-foundation.org