Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta 9 release page #920 #929

Merged
merged 48 commits into from Nov 12, 2020

Conversation

flora8984461
Copy link
Contributor

@flora8984461 flora8984461 commented Oct 26, 2020

Fix #920

Tasks:

--------New tasks on Nov 6----------------

-------------- Finished tasks ------------------

Signed-off-by: Yi Liu yi.liu@eclipse-foundation.org

------------------- We choose this one ---------------------------------------------------

In #926 , I use a separate image for the boat logo to overlap on the bg,

image

In this comparison, I use a combined bg img.

image

The main point is not the opacity, it's more about how will it show better on responsive and zoom in and out.🤔
How they are reflecting when zoom and on mobile is a little different,
And I need your suggestions on how I can improve this section.

Signed-off-by: Yi Liu yi.liu@eclipse-foundation.org

Yi Liu added 6 commits October 23, 2020 09:20
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
@netlify
Copy link

netlify bot commented Oct 26, 2020

Deploy preview for jakartaee ready!

Built with commit 993a7e0

https://deploy-preview-929--jakartaee.netlify.app

Yi Liu added 4 commits October 27, 2020 10:17
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
@flora8984461 flora8984461 marked this pull request as ready for review October 27, 2020 19:21
@flora8984461 flora8984461 changed the title This is just a comparison of Download Now Section with #926 Jakarta 9 release page #920 Oct 27, 2020
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
layouts/release/section.html Outdated Show resolved Hide resolved
layouts/shortcodes/pages/release.html Outdated Show resolved Hide resolved
less/styles.less Outdated Show resolved Hide resolved
Copy link
Contributor

@autumnfound autumnfound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, if we are using static/images/release-download-9-bg.jpg, we should shrink it, otherwise remove it

layouts/release/section.html Outdated Show resolved Hide resolved
layouts/shortcodes/pages/release.html Outdated Show resolved Hide resolved
layouts/shortcodes/pages/release.html Outdated Show resolved Hide resolved
layouts/release/section.html Outdated Show resolved Hide resolved
<div class="jumbotron featured-jumbotron featured-jumbotron-download vertical-align flex-column margin-bottom-0">

<div class="flex-grow vertical-align-space-evenly flex-wrap">
<div class="col-md-10 flex-column">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

around tablet, past desktop bp

tablet bp

issues with font size around break points (too big for container) and very large (potentially unintentional) space at smaller break points

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By applying flex-grow: 1; when only big screen view seems better, and also removed the space-between it removes the unnecessary space on mobile /tablet view

less/release-9.less Outdated Show resolved Hide resolved
layouts/shortcodes/pages/release.html Outdated Show resolved Hide resolved
less/release-9.less Outdated Show resolved Hide resolved
<div class="white-paper-bg">
<div class="col-lg-12 col-md-16 col-sm-24 col-lg-offset-3 col-md-offset-4 col-sm-offset-4 col-xs-offset-2 white-paper-download">
<p class="text-white vcenter"><img width="120" alt="white-paper-icon" class="icon" src="images/release-9/icon5.svg"></p>
<h2 class="fw-600 vcenter text-blue"><strong>NEW TECHNICAL<br>WHITE PAPER</strong></h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

We should add some additional rules to this, it doesn't look great

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the screen size for this?

This does have an issue that if zoom in or out, or change screen size the words comes out of the yellow image. That's why we change the text to blue.

Or I can try to adjust in different screen sizes, keep the words inside the yellow block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some adjustments and use a yellow block in the mobile view.

layouts/release/section.html Outdated Show resolved Hide resolved
Copy link
Contributor

@autumnfound autumnfound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to switch to request changes, oops

Yi Liu added 6 commits October 28, 2020 12:35
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Yi Liu added 2 commits November 6, 2020 15:26
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
@chrisguindon
Copy link
Member

chrisguindon commented Nov 10, 2020

@karenmcnaughton @TanjaObradovic can you please confirm that the content is good and that all the links are correct? We believe that the Download Now and Watch the video interview links are currently incorrect.

We are waiting for your +1 to push this on the website.

Yi Liu added 3 commits November 11, 2020 15:19
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
@chrisguindon
Copy link
Member

@flora8984461 I just spoke with @karenmcnaughton and we would like to make the following changes before we can merge this:

  • Remove/hide the "watch the video interviews" button for now
  • Disable the "Download Now" button in the new technical white paper section and replace the text with "coming soon"

Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
@flora8984461
Copy link
Contributor Author

@flora8984461 I just spoke with @karenmcnaughton and we would like to make the following changes before we can merge this:

  • Remove/hide the "watch the video interviews" button for now
  • Disable the "Download Now" button in the new technical white paper section and replace the text with "coming soon"

Did the change and waiting for the preview to be built.

@chrisguindon
Copy link
Member

@karenmcnaughton I think we need to add the release date in the header to let people know this is not live but coming up soon. How about adding this below Previous Releases: Jakarta EE 8:

Jakarta EE 9 is coming on December 8

^We would then want to remove that text on December 8.

@karenmcnaughton
Copy link

@chrisguindon that works--thank you!

Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
@flora8984461
Copy link
Contributor Author

@karenmcnaughton I think we need to add the release date in the header to let people know this is not live but coming up soon. How about adding this below Previous Releases: Jakarta EE 8:

Jakarta EE 9 is coming on December 8

^We would then want to remove that text on December 8.

Updated.

Copy link
Member

@chrisguindon chrisguindon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, some of the images are bigger than 100kb... is it possible to shrink them without lowering too much the quality?

layouts/shortcodes/pages/release/8.html Outdated Show resolved Hide resolved
layouts/shortcodes/pages/release/8.html Outdated Show resolved Hide resolved
layouts/shortcodes/pages/release/8.html Outdated Show resolved Hide resolved
layouts/shortcodes/pages/release/8.html Outdated Show resolved Hide resolved
less/release-9.less Outdated Show resolved Hide resolved
@@ -0,0 +1,351 @@
.flex-wrap {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be added to solstice-assets:

https://github.com/EclipseFdn/solstice-assets/blob/master/less/_components/classes-grid.less

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, will submit a patch for it.

less/release-9.less Outdated Show resolved Hide resolved
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Yi Liu added 2 commits November 12, 2020 14:10
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
@flora8984461
Copy link
Contributor Author

flora8984461 commented Nov 12, 2020

Finally, some of the images are bigger than 100kb... is it possible to shrink them without lowering too much the quality?

static/images/jakarta9-image.png is very big, but I have tried some online tools, not quite successful to compress, wondering if you guys or the marketing team can have a better way to compress it?

Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Yi Liu and others added 4 commits November 12, 2020 14:52
@chrisguindon chrisguindon merged commit 00f835f into jakartaee:src Nov 12, 2020
@karenmcnaughton
Copy link

@chrisguindon pls change the text Previous Releases: Jakarta EE 8 to Previous Release -- [drop the plural]--thanks!

@flora8984461 flora8984461 mentioned this pull request Nov 13, 2020
@flora8984461 flora8984461 deleted the yiliu/src/comparisonDownload branch November 20, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the Jakarta EE 9 release page (redesign of Jakarta EE 8 release page)
6 participants