Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a favicon to the documentation UI #21

Closed
kito99 opened this issue Nov 6, 2023 · 1 comment
Closed

Add a favicon to the documentation UI #21

kito99 opened this issue Nov 6, 2023 · 1 comment
Assignees
@kito99
Labels
help wanted Extra attention is needed

Comments

@kito99
Copy link
Contributor

kito99 commented Nov 6, 2023

Currently, the documentation has no favicon (the icon displayed in the tab header). It should have one that matches the one on the main Jakarta EE site.

The favicon can be found here: https://github.com/jakartaee/jakarta.ee/blob/src/static/images/jakarta/favicon.ico.
You can add it to the UI by following these steps: https://docs.antora.org/antora-ui-default/add-static-files/
@kito99 kito99 added the help wanted Extra attention is needed label Nov 6, 2023
@kito99
Copy link
Contributor Author

kito99 commented Nov 9, 2023

@jhammen this is a good candidate.

jhammen added a commit to jhammen/jakartaee-documentation-ui that referenced this issue Nov 13, 2023
@jhammen
add favicon jakartaee#21
3f696b3
@jhammen jhammen mentioned this issue Nov 13, 2023
Merged
@kito99 kito99 self-assigned this Nov 15, 2023
kito99 added a commit that referenced this issue Nov 15, 2023
@kito99
Merge pull request #23 from jhammen/feature/add_favicon_21
359519e 
add favicon #21
@kito99 kito99 closed this as completed Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kito99 kito99

Labels
help wanted Extra attention is needed
Projects
Jakarta EE Tutorial Refresh
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kito99