Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup compile-time warnings introduced through recent additions #481

Closed
lukasj opened this issue Aug 21, 2023 · 1 comment · Fixed by #482
Closed

Cleanup compile-time warnings introduced through recent additions #481

lukasj opened this issue Aug 21, 2023 · 1 comment · Fixed by #482
Projects
3.2.0

Comments

@lukasj
Copy link
Contributor

lukasj commented Aug 21, 2023

ie PersistenceConfiguration is missing a constructor - ie do we want to have just default public one and/or rather a specific one taking some arguments?
@lukasj lukasj added this to To do in 3.2.0 via automation Aug 21, 2023
gavinking added a commit to gavinking/jpa-api that referenced this issue Aug 22, 2023
@gavinking
improvements to PersistenceConfiguration
f89b60c 
1. add constructor taking name, and make name immutable
2. clarify rules for vendor subclasses
3. add constant property names
4. improve javadoc

see jakartaee#481, jakartaee#139
@gavinking gavinking mentioned this issue Aug 22, 2023
Merged
@gavinking gavinking linked a pull request Aug 22, 2023 that will close this issue
improvements to PersistenceConfiguration #482
Merged
@gavinking
Copy link
Contributor

@lukasj please review #482 which I think addresses your concerns and more.

@lukasj lukasj moved this from To do to In progress in 3.2.0 Aug 22, 2023
gavinking added a commit to gavinking/jpa-api that referenced this issue Aug 22, 2023
@gavinking
improvements to PersistenceConfiguration
462771a 
1. add constructor taking name, and make name immutable
2. clarify rules for vendor subclasses
3. fix compiler warnings using final
4. improve javadoc

see jakartaee#481
lukasj pushed a commit that referenced this issue Aug 22, 2023
@gavinking @lukasj
improvements to PersistenceConfiguration
51c76aa 
1. add constructor taking name, and make name immutable
2. clarify rules for vendor subclasses
3. fix compiler warnings using final
4. improve javadoc

see #481
3.2.0 automation moved this from In progress to Done Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
3.2.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvements to PersistenceConfiguration gavinking/jpa-api
2 participants
@gavinking @lukasj