Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to PersistenceConfiguration #482

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

gavinking
Copy link
Contributor

see #481, #139

1. add constructor taking name, and make name immutable
2. clarify rules for vendor subclasses
3. fix compiler warnings using final
4. improve javadoc

see jakartaee#481
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj linked an issue Aug 22, 2023 that may be closed by this pull request
@lukasj lukasj merged commit 42155f8 into jakartaee:master Aug 22, 2023
4 checks passed
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Aug 30, 2023
jakartaee/persistence#482 - Improvements to PersistenceConfiguration

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Aug 31, 2023
jakartaee/persistence#482 - Improvements to PersistenceConfiguration

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Oct 17, 2023
jakartaee/persistence#482 - Improvements to PersistenceConfiguration

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
lukasj pushed a commit to eclipse-ee4j/eclipselink that referenced this pull request Oct 17, 2023
jakartaee/persistence#482 - Improvements to PersistenceConfiguration

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup compile-time warnings introduced through recent additions Provide constants for properties
2 participants