Add changes from release-3.1.x and release-4.0 TCK to release-3.2 #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-krueger
force-pushed
the
move-3.1.x-tck-to-3.2
branch
2 times, most recently
from
bbadd63
to
93ddc33
Compare
jim-krueger
force-pushed
the
move-3.1.x-tck-to-3.2
branch
from
93ddc33
to
4e712dc
Compare
jamezp
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
This looks good to me. I agree with reverting #863 as well. There was a comment on #859 (comment) which indicated:
Anyway, it is a backward-incompatible change, and as such, it should go into a major version, not minor 3.1, imho.
I agree with that statement.
jansupol
approved these changes
Feb 14, 2024
asoldano
approved these changes
Feb 15, 2024
jamezp
approved these changes
Feb 15, 2024
jim-krueger
force-pushed
the
move-3.1.x-tck-to-3.2
branch
from
351401d
to
1638122
Compare
jamezp
approved these changes
Feb 15, 2024
jim-krueger
changed the title
|
Updated to include nearly all of the TCK changes in 4.0 as well. Exceptions to this are noted in the description above. |
jamezp
approved these changes
Feb 20, 2024
|
Could you please review this PR @alwin-joseph? |
spericas
approved these changes
Feb 20, 2024
asoldano
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled in changes from the following 3.1.x PR's:
#1139
#1173
#1181
#1184
#1200
Pulled in changes from the following 4.0 PR's:
#863
#1146
#1164
#1172
#1182
Removed changes from PR 864 since this change is a breaking change and needs to go in a full release.
Still needs fix to Issue 1138 and then the exclude list can be updated.