-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changes from release-3.1.x and release-4.0 TCK to release-3.2 #1220
Add changes from release-3.1.x and release-4.0 TCK to release-3.2 #1220
Conversation
bbadd63
to
93ddc33
Compare
93ddc33
to
4e712dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I agree with reverting #863 as well. There was a comment on #859 (comment) which indicated:
Anyway, it is a backward-incompatible change, and as such, it should go into a major version, not minor 3.1, imho.
I agree with that statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If time permits, we should come up with a fix for the disabled tests for 3.2
351401d
to
1638122
Compare
Updated to include nearly all of the TCK changes in 4.0 as well. Exceptions to this are noted in the description above. |
Could you please review this PR @alwin-joseph? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we should get @alwin-joseph to review as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Pulled in changes from the following 3.1.x PR's:
#1139
#1173
#1181
#1184
#1200
Pulled in changes from the following 4.0 PR's:
#863
#1146
#1164
#1172
#1182
Removed changes from PR 864 since this change is a breaking change and needs to go in a full release.
Still needs fix to Issue 1138 and then the exclude list can be updated.