-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bean Validation 3.0 final PR #222
Conversation
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Deploy preview for jakartaee-specifications ready! Built with commit be3275d https://deploy-preview-222--jakartaee-specifications.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@starksm64, a few items to work out... I've embedded some specific comments as part of the code review. And, I also notice that there is Certification Request for the CI posted yet.
I will also post the secondary checklist to help with ensuring that everything is in place for the final ballot. Thanks!
Spec Review Checklist
|
@starksm64 When will these review comments be addressed? Thanks! |
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The _index.md information for the TCK artifacts needs to be updated. Thanks!
The TCK SHA 2456 values don't match... I downloaded your TCK here's what I get... Kevins-MacBook-Pro:Downloads sutter@us.ibm.com$ shasum -a 256 beanvalidation-tck-dist-3.0.0.zip But, the value specified here and in the certification request is this: |
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Spec committee gives contingent approval upon final review by the mentor, @kwsutter. Kevin will put up for ballot after review. |
Signed-off-by: Scott M Stark <starksm64@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @starksm64!
@starksm64 I found something... Maybe you can answer this... Your maven coordinates for the API in the _index.md file are these: But, bean validation has been using these coordinates (validation instead of bean-validation). There is even a 3.0.0 release already there: I know that bean-validation is the official Jakarta EE 9 "short name", but I wanted to verify that you really wanted to make this change. Also, the final TCK URL in _index.md should be of the form (with jakartaee directory): You currently have (with ee4j directory): Thanks! |
@starksm64 One more thing... The SHA 256 value for the TCK needs to be updated on the Certification Request and the TCK Results. |
Done |
@starksm64, any comments on this...
|
Signed-off-by: Scott M Stark <starksm64@gmail.com>
It has been corrected to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need another update, it looks like... Thanks!
Signed-off-by: Scott M Stark <starksm64@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Finally! :-) Thanks, @starksm64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct this link
Signed-off-by: Scott M Stark <starksm64@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, just a question regarding the file name.
There is also a typo
<p>The only changes in Bean Validation 3.0 are changes to support the Jarkarta EE javax to jakarta package namespace change.</p>
Jarkarta instead of Jakarta
Left some minor comments, so want to make sure someone can look at them
Good catch, but it's kind of a nit. Especially since this Specification has already passed it's ballot. Go ahead and create an Issue or PR against the BV project to get this corrected in the next update. Thanks. |
Now that the ballot is complete, there are a few more things to do...
|
Per our updated process, moving these items to a separate issue against the Spec Project:
|
Signed-off-by: Scott M Stark starksm64@gmail.com
Include the following in PR#1:
https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
is complete, passes the TCK, and that the TCK includes sufficient
coverage of the specification. The TCK users guide MUST include
the instructions to run the compatible implementations used to
validate the release. Instructions MAY be by reference.
https://jakarta.oss.sonatype.org/content/groups/staging/jakarta/validation/jakarta.validation-api/3.0.0/
https://download.eclipse.org/ee4j/bean-validation/3.0/beanvalidation-tck-dist-3.0.0.zip
Compatibility certification request for Hibernate Validator for BV 3.0.0 validation-spec#260
Include the following in PR#2: