Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.1 Specifications page updates #372

Merged
merged 10 commits into from
May 19, 2021
Merged

Conversation

kwsutter
Copy link
Contributor

@kwsutter kwsutter commented Apr 22, 2021

Signed-off-by: Kevin Sutter kwsutter@gmail.com

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

NOTE: This PR is covering both the Platform and Web Profile Specifications for Jakarta EE 9.1. So, you need to review both directory structures: https://deploy-preview-372--jakartaee-specifications.netlify.app/specifications/platform/9.1/ and https://deploy-preview-372--jakartaee-specifications.netlify.app/specifications/webprofile/9.1/.

Include the following in the PR:

Note: If any item does not apply, check it and mark N/A below it.

NOTE: I am also including an update to the 9.0 pages for the multiple TCKs that have been produced since the 9.0.0 TCK.

Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@kwsutter
Copy link
Contributor Author

kwsutter commented Apr 22, 2021

Still in Draft form... Waiting for a few minor changes on the Platform Spec and API pom to be completed before generating the final versions. Tomitribe (@dblevins and @jeanouii) was asked to be mentors of this effort. I'll take comments at any time (even before I take it out of Draft mode). Thanks!

@netlify
Copy link

netlify bot commented Apr 22, 2021

Deploy Preview for jakartaee-specifications ready!

Built with commit 6cf29df

https://deploy-preview-372--jakartaee-specifications.netlify.app

Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@kwsutter kwsutter marked this pull request as ready for review April 27, 2021 23:18
@kwsutter
Copy link
Contributor Author

Took this out of Draft mode. It's pretty much ready for review. Still waiting on Open Liberty and Wildfly for their CCRs, but otherwise review away... Due to the huge number of javadoc files, I'd suggest using the https://deploy-preview-372--jakartaee-specifications.netlify.app/ preview. Thanks!

Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@gerdogdu
Copy link

gerdogdu commented May 3, 2021

@kwsutter I have also added our certification request via jakartaee/platform#350
I will be updating our test results pages, some couple of tests are remaining in the run...
Thanks.
Gurkan

@gerdogdu
Copy link

gerdogdu commented May 3, 2021

@kwsutter We have finished to run tests and updated our Test Results page.

@kwsutter
Copy link
Contributor Author

kwsutter commented May 3, 2021

@kwsutter I have also added our certification request via eclipse-ee4j/jakartaee-platform#350
I will be updating our test results pages, some couple of tests are remaining in the run...
Thanks.
Gurkan

Hi, @gerdogdu. Per my comments on your CCR (jakartaee/platform#350), I don't see a need to repeat the designation of a Glassfish derivative as a CI used for ratification. As a reminder, the CI's used for the ballot are only for demonstrating that the Specification is implementable and testable. Eclipse Glassfish has already provided that capability. Unless ManagedCat is modifying or adding new features to Glassfish, there really is no reason to include it on the ballot since there is nothing "new" with this derivative. Make sense?

But, please do follow through on the process to get ManagedCat listed on the Compatible Products page!

@gerdogdu
Copy link

gerdogdu commented May 3, 2021

Hi Kevin,
I have replied to eclipse-ee4j/jakartaee-platform#350

Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@jeanouii
Copy link
Contributor

jeanouii commented May 3, 2021

@kwsutter ManageFish PR got approved just on time.
If you can add it to this PR with the links, I'm ready to send out the ballot email.

@edbratt
Copy link
Contributor

edbratt commented May 3, 2021

For consistency, would it be appropriate to point at the Specific WildFly .zip downloads?

@jeanouii
Copy link
Contributor

jeanouii commented May 3, 2021

@edbratt I think so. @starksm64 thoughts?

Copy link
Contributor

@jeanouii jeanouii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Please don't update the PR from now on as the vote will go off for ballot and we should not change the PR while the vote is up.

@kwsutter
Copy link
Contributor Author

kwsutter commented May 4, 2021

Looks good to me.
Please don't update the PR from now on as the vote will go off for ballot and we should not change the PR while the vote is up.

@jeanouii Your previous comments suggested an update to include ManagedCat. And, with @edbratt's comment, you thought it was a good idea to include a specific link to the Wildfly download. But, then I saw this comment that said the PR is frozen because the vote had been started...

I see that @ivargrimstad has posted a similar concern on the Ballot thread. I think these updates should be performed and whether the vote needs to be restarted or not is something we can discuss at tomorrow's Spec Committee call. Since nobody has formally voted yet, we may be okay...

Thanks!

…TomEE link for Platform

Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@kwsutter
Copy link
Contributor Author

kwsutter commented May 4, 2021

All,
A couple of minor updates to answer the questions previously posted...

  • Removed the errant entry for TomEE at the Platform level
  • Added an entry for ManageFish 6.1 at the Platform level
  • Modified the links for the WildFly download to be more specific

We will be discussing the ManageFish CI request and the impact of these changes to the active ballot at tomorrow's Spec Committee call. To that end, these may not be the final changes... :-)

Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
Copy link
Contributor

@jeanouii jeanouii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.
As discussed, PR updates look good and match our discussion.
No one voted yet so we are good

@kwsutter kwsutter added ballot Delivered to the Specification Committee for ballot final Ready for Vote labels May 4, 2021
@jeanouii
Copy link
Contributor

Ballot completed today on time
https://www.eclipse.org/lists/jakarta.ee-spec/msg01722.html

Ready to go. Thank you Kevin and everyone

@dblevins
Copy link
Contributor

Couple minor updates if we move forward with this format. ASF infra reminded us we need to use the mirrors link, which would be:

Also, we need to ensure "TomEE" is updated to "Apache TomEE"

@gerdogdu
Copy link

Our ManageFish download link has also changed to below link and we also updated the link in our compatibility request issue

Regards.

@jeanouii jeanouii added approved The ballot was approved by the Specification Committee and removed ballot Delivered to the Specification Committee for ballot labels May 19, 2021
@jeanouii
Copy link
Contributor

jeanouii commented May 19, 2021

@jeanouii
Copy link
Contributor

@kwsutter added the checklist to conclude the ballot. Can you do the 2 small changes from David and Gurkan?

@kwsutter
Copy link
Contributor Author

@kwsutter added the checklist to conclude the ballot. Can you do the 2 small changes from David and Gurkan?

Yes, doing that now. Thanks!

Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@kwsutter kwsutter merged commit ac1ca2e into jakartaee:master May 19, 2021
@kwsutter kwsutter deleted the spec-9.1 branch May 19, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee final Ready for Vote platform Run ballot with the Jakarta Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants