-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9.1 Specifications page updates #372
Conversation
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
Deploy Preview for jakartaee-specifications ready! Built with commit 6cf29df https://deploy-preview-372--jakartaee-specifications.netlify.app |
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
Took this out of Draft mode. It's pretty much ready for review. Still waiting on Open Liberty and Wildfly for their CCRs, but otherwise review away... Due to the huge number of javadoc files, I'd suggest using the https://deploy-preview-372--jakartaee-specifications.netlify.app/ preview. Thanks! |
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@kwsutter I have also added our certification request via jakartaee/platform#350 |
@kwsutter We have finished to run tests and updated our Test Results page. |
Hi, @gerdogdu. Per my comments on your CCR (jakartaee/platform#350), I don't see a need to repeat the designation of a Glassfish derivative as a CI used for ratification. As a reminder, the CI's used for the ballot are only for demonstrating that the Specification is implementable and testable. Eclipse Glassfish has already provided that capability. Unless ManagedCat is modifying or adding new features to Glassfish, there really is no reason to include it on the ballot since there is nothing "new" with this derivative. Make sense? But, please do follow through on the process to get ManagedCat listed on the Compatible Products page! |
Hi Kevin, |
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@kwsutter ManageFish PR got approved just on time. |
For consistency, would it be appropriate to point at the Specific WildFly .zip downloads? |
@edbratt I think so. @starksm64 thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Please don't update the PR from now on as the vote will go off for ballot and we should not change the PR while the vote is up.
@jeanouii Your previous comments suggested an update to include ManagedCat. And, with @edbratt's comment, you thought it was a good idea to include a specific link to the Wildfly download. But, then I saw this comment that said the PR is frozen because the vote had been started... I see that @ivargrimstad has posted a similar concern on the Ballot thread. I think these updates should be performed and whether the vote needs to be restarted or not is something we can discuss at tomorrow's Spec Committee call. Since nobody has formally voted yet, we may be okay... Thanks! |
…TomEE link for Platform Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
All,
We will be discussing the ManageFish CI request and the impact of these changes to the active ballot at tomorrow's Spec Committee call. To that end, these may not be the final changes... :-) |
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect.
As discussed, PR updates look good and match our discussion.
No one voted yet so we are good
Ballot completed today on time Ready to go. Thank you Kevin and everyone |
Couple minor updates if we move forward with this format. ASF infra reminded us we need to use the mirrors link, which would be: Also, we need to ensure "TomEE" is updated to "Apache TomEE" |
Our ManageFish download link has also changed to below link and we also updated the link in our compatibility request issue Regards. |
|
@kwsutter added the checklist to conclude the ballot. Can you do the 2 small changes from David and Gurkan? |
Yes, doing that now. Thanks! |
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
Signed-off-by: Kevin Sutter kwsutter@gmail.com
Specification PR template
When creating a specification project release review, create PRs with the content defined as follows.
NOTE: This PR is covering both the Platform and Web Profile Specifications for Jakarta EE 9.1. So, you need to review both directory structures: https://deploy-preview-372--jakartaee-specifications.netlify.app/specifications/platform/9.1/ and https://deploy-preview-372--jakartaee-specifications.netlify.app/specifications/webprofile/9.1/.
Include the following in the PR:
https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
For a Progress Review, that sufficient progress has been made on a Compatible Implementation and TCK, to ensure that the spec is implementable and testable.N/A
Instructions MAY be by reference.
https://jakarta.oss.sonatype.org/content/repositories/jakartaplatform-1015/jakarta/platform/jakarta.jakartaee-api/9.1.0/
https://jakarta.oss.sonatype.org/content/repositories/jakartaplatform-1015/jakarta/platform/jakarta.jakartaee-web-api/9.1.0/
https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/promoted/jakarta-jakartaeetck-9.1.0.zip
Platform
- Glassfish 6.1 RC1 (JDK 11): Compatibility certification request for Eclipse GlassFish 6.1 RC1, Jakarta EE Platform, 9.1 platform#334
- Glassfish 6.0 (JDK 8): Compatibility certification request for Eclipse GlassFish 6.0, Jakarta EE Platform 9.1 platform#337
- ManageFish 6.1.0 (JDK 11): Compatibility certification request for ManageCat ManageFish Server for Jakarta EE (Full) Platform, 9.1 platform#350
- Open Liberty 21.0.0.3-Beta (JDK 11): Compatibility certification request for Open Liberty for Jakarta EE 9.1, Full Platform, Java 11 platform#343
- Open Liberty 21.0.0.3-Beta (JDK 8): Compatibility certification request for Open Liberty for Jakarta EE 9.1, Full Platform, Java 8 platform#344
- WildFly Preview 23.0.2.Final (JDK 11): Compatibility certification request for WildFly Preview for Jakarta EE 9.1, Full Platform, Java 11 platform#346
- WildFly Preview 23.0.2.Final (JDK 8): Compatibility certification request for WildFly Preview for Jakarta EE 9.1, Full Platform, Java 8 platform#348
Web Profile
- Glassfish 6.1 RC1 (JDK 11): Compatibility certification request for Eclipse GlassFish Web Profile, 6.1 RC1, Jakarta EE Platform 9.1 Web Profile platform#335
- Glassfish 6.0 (JDK 8): Compatibility certification request for Eclipse GlassFish 6.0, Jakarta EE Platform Web Profile 9.1 platform#336
- Open Liberty 21.0.0.3-Beta (JDK 11): Compatibility certification request for Open Liberty for Jakarta EE 9.1, Web Profile, Java 11 platform#341
- Open Liberty 21.0.0.3-Beta (JDK 8): Compatibility certification request for Open Liberty for Jakarta EE 9.1, Web Profile, Java 8 platform#342
- TomEE 9.0.0-M7 (JDK 11): Compatibility certification request for Apache TomEE for Jakarta EE 9.1, Web Profile, Java 11 platform#351
- WildFly Preview 23.0.2.Final (JDK 11): Compatibility certification request for WildFly Preview for Jakarta EE 9.1, Web Profile, Java 11 platform#347
- WildFly Preview 23.0.2.Final (JDK 8): Compatibility certification request for WildFly Preview for Jakarta EE 9.1, Web Profile, Java 8 platform#349
Note: If any item does not apply, check it and mark N/A below it.
NOTE: I am also including an update to the 9.0 pages for the multiple TCKs that have been produced since the 9.0.0 TCK.