-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta Expression Language 3.0 apidocs #41
Jakarta Expression Language 3.0 apidocs #41
Conversation
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original Oracle copyright needs to be preserved, and a speclicense.html file needs
to be included containing the EFSL license text, and a link to the license file needs to be
included in the page footer text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the footer includes a copyright line with the years "2017-2019", but Eclipse didn't own this content before 2019.
- the footer is also missing the link to the license, and the license file is missing
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
License, link and eclipse copyright updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor issue, otherwise fine.
.project
Outdated
@@ -0,0 +1,11 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what this file is but it doesn't belong here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm extremely sorry that this got committed. It's from my local editor. I'll remove it right away.
P.s. Would you be okay with a separate PR for a .gitignore that excludes the usual stuff like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A .gitignore for the specifications repository would be fine.
It could also ignore the META-INF directory that sometimes
is accidentally included with the javadocs.
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms arjan.tijms@gmail.com
Include the following in PR#2: