Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta Expression Language 3.0 apidocs #41

Merged
merged 3 commits into from
Sep 3, 2019

Conversation

arjantijms
Copy link
Contributor

Signed-off-by: arjantijms arjan.tijms@gmail.com

Include the following in PR#2:

  • Specification JavaDoc in the wombat/x.y/apidocs directory.

Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Copy link
Contributor

@bshannon bshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original Oracle copyright needs to be preserved, and a speclicense.html file needs
to be included containing the EFSL license text, and a link to the license file needs to be
included in the page footer text.

Copy link
Contributor

@bshannon bshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the footer includes a copyright line with the years "2017-2019", but Eclipse didn't own this content before 2019.
  • the footer is also missing the link to the license, and the license file is missing

@ivargrimstad ivargrimstad self-requested a review August 7, 2019 16:09
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
@arjantijms
Copy link
Contributor Author

License, link and eclipse copyright updated

Copy link
Contributor

@bshannon bshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue, otherwise fine.

.project Outdated
@@ -0,0 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what this file is but it doesn't belong here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm extremely sorry that this got committed. It's from my local editor. I'll remove it right away.

P.s. Would you be okay with a separate PR for a .gitignore that excludes the usual stuff like this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A .gitignore for the specifications repository would be fine.
It could also ignore the META-INF directory that sometimes
is accidentally included with the javadocs.

Signed-off-by: arjantijms <arjan.tijms@gmail.com>
@ivargrimstad ivargrimstad removed the draft Work in Progress label Aug 10, 2019
@ivargrimstad ivargrimstad marked this pull request as ready for review August 10, 2019 11:46
@kwsutter kwsutter added the draft Work in Progress label Aug 12, 2019
@starksm64 starksm64 added final Ready for Vote and removed draft Work in Progress labels Aug 16, 2019
@waynebeaton waynebeaton added the ballot Delivered to the Specification Committee for ballot label Aug 19, 2019
@waynebeaton waynebeaton added the approved The ballot was approved by the Specification Committee label Sep 3, 2019
@kwsutter kwsutter merged commit c2bd548 into jakartaee:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee ballot Delivered to the Specification Committee for ballot final Ready for Vote
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants