Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the automatic module names #357

Closed
keilw opened this issue Aug 24, 2020 · 4 comments
Closed

Remove the automatic module names #357

keilw opened this issue Aug 24, 2020 · 4 comments

Comments

@keilw
Copy link
Member

keilw commented Aug 24, 2020

The automatic module name does not comply with the JPMS module naming conventions as it has "api" at the end.
Since this was not present in Jakarta EE 8 yet either, and Websocket has an additional complication by "client" and "server" APIs the recommendation by the Spec Committee is to remove it from the POM and revisit the module name (automatic or fully qualified module-info) after Jakarta EE 9.

@joakime
Copy link
Contributor

joakime commented Aug 24, 2020

Where are these recommendations by the Spec Committee?
Got a link?

@keilw
Copy link
Member Author

keilw commented Sep 15, 2020

We gather the analysis here: https://docs.google.com/spreadsheets/d/1g8jYG0JixO3wzZkpeyU1LMIQRhbnZ76kGtdMFE8mieE/edit#gid=0 with Websocket the only one unresolved.
This is the Google Doc with the analysis of options: https://docs.google.com/document/d/1LAAHKPJyREky9fEKv0xFd9IRDgXB58It53ryfyrNPtg/edit
Option F is noted as having a clear preference by the Spec Committee and all other specs have followed it.

@keilw
Copy link
Member Author

keilw commented Sep 16, 2020

OSGi bundles "jakarta.websocket" and "jakarta.websocket.client" already existed in Jakarta EE 8 although there they also matched the old package namespace, so I recommend, we keep the automatic-module names but without the "api" so they are also aligned with the OSGi module definitions that existed before.

keilw added a commit to keilw/websocket-api that referenced this issue Sep 16, 2020
Task-Url: jakartaee#357

Signed-off-by: Werner Keil <werner.keil@gmx.net>
keilw added a commit to keilw/websocket-api that referenced this issue Sep 16, 2020
Task-Url: jakartaee#357

Signed-off-by: Werner Keil <werner.keil@gmx.net>
markt-asf pushed a commit that referenced this issue Sep 18, 2020
Task-Url: #357

Signed-off-by: Werner Keil <werner.keil@gmx.net>
@markt-asf
Copy link
Contributor

Resolved via #358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants