Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Minor improvements #7

wants to merge 3 commits into from

Conversation

va-li
Copy link

@va-li va-li commented Sep 26, 2023

Proposed changes:

  • Allow using *.tiff (not only *.tif) images, Pillow supports them
  • Image paths were sorted only before being used in the corner detection, breaking the connection between the order of processed images and the order they are written in to the result JSON. (Probably the sorting before iterating over the data variables in different parts of the code can be removed.)
  • When no valid pattern was detected by the linear estimation, numpy would show a RuntimeWarning that the mean of an empty slice was calculated, which was a hint for the following problem:
  • When no valid pattern was detected by the linear estimation, the code for get_taylor_linear() would crash, because it's valid: List[bool] argument was in fact None. This was fixed with a check if the linear estimation was successful, and in case it was not an error is logged prompting the user to check the input images and the program now raises a ValueError

@va-li va-li changed the title Allow *.tiff images and other minor improvements Minor improvements Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant