-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying msvc manifest file to use #6
Comments
Makes sense! |
Yes please! This would be very nice for CI builds as well. |
So as it turns out, there's still a reproducibility issue somewhere. On one machine, I get |
Actually, it looks like it might be this: https://github.com/Jake-Shadle/xwin/blob/main/src/splat.rs#L317 |
Removing that check seems to make the output reproducible, or at least a lot more reproducible: K900@b1de334 |
Ahh ok, that's unfortunate, if every SDK header is written then the output will contain a lot of duplicates, so I'll need to change this to filter out those duplicates in a deterministic manner. |
I tried switching it to use a BTreeMap and that seems to work, but only in single thread. |
Hello, I'd like to integrate this tool in my nix-based msvc toolchain, replacing vsdownload.py from msvc-wine. But in order to do this, I need to ensure I can reproducibly download the source files from Microsoft.
To do so, vsdownload.py provides the ability to specify a manifest file, which is then used as-is instead of fetching the file from microsoft. See this. Downloading files from this pinned manifest is fully reproducible, as it pins the hash of all its sub-resources.
Having a similar ability in xwin would be great.
The text was updated successfully, but these errors were encountered: