-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cache-clean test #6
Closed
timmywil
wants to merge
26
commits into
jakearchibald:task-clean-photos
from
timmywil:task-clean-photos
Closed
Fix cache-clean test #6
timmywil
wants to merge
26
commits into
jakearchibald:task-clean-photos
from
timmywil:task-clean-photos
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
force-pushed
the
task-clean-photos
branch
from
August 29, 2016 00:50
aa248f8
to
b2a3847
Compare
- The cache-clean test expected photos to be cached by the time it gets a response, but the service worker is responding before the put to the cache has completed.
timmywil
force-pushed
the
task-clean-photos
branch
from
August 29, 2016 00:53
b2a3847
to
d31fb28
Compare
jakearchibald
force-pushed
the
task-clean-photos
branch
from
September 14, 2016 12:55
c492001
to
78f7e2f
Compare
Fixed with d795679 Consuming the image as a blob is the bit that I was missing, that means the rest of my code runs once the image has been fully fetched. Added a 500ms delay just to be sure. Thanks for spotting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are more easily viewed with ?w=1.
but the service worker is responding before the put to the cache has completed. Adding a short timeout before checking the cache fixes the issue, while still allowing the sw to respond immediately.