Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata inconsistency for links and user mentions #74

Open
crokkon opened this issue Aug 29, 2018 · 0 comments
Open

Metadata inconsistency for links and user mentions #74

crokkon opened this issue Aug 29, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@crokkon
Copy link

crokkon commented Aug 29, 2018

Expected behavior

steeditor should put URLs and user mentions from the post body in the corresponding json_metadata fields

Actual behavior

How to reproduce

Two test posts with the same body: utopian template + one image + a markdown link

{"app":"steeditor/0.1.0",
"format":"markdown",
"image":["https://steemitimages.com/0x0/https://user-images.githubusercontent.com/33018033/42889616-25f17de6-8aab-11e8-971e-e05abdb331e1.png"],
"tags":["not-utopian","not-analysis"],
"users":["stmdev"],
"links":["https://steemit.com/test/@stmdev/steeditor-test-1532283370486"],
"community":"steeditor"}
{"tags":["not-utopian","not-analysis"],
"image":["https://steemitimages.com/0x0/https://user-images.githubusercontent.com/33018033/42889616-25f17de6-8aab-11e8-971e-e05abdb331e1.png"],
"links":["https://github.com/utopian-io/utopian.io","https://steemit.com/test/@stmdev/steeditor-test-1532283370486"],
"app":"steemit/0.1",
"format":"markdown"}

Differences:

  • The steeditor metadata doesn't contain the repository in the links section, so the target repository may be empty or possibly wrong in the utopian review sheet. The steemit metadata contains the repository as the first entry in links
  • The steeditor metadata detects a user mention in the markdown link for @stmdev, while steemit treats this as part of the URL and doesn't add a users field.

Environement

steeditor.app as live on 2018-08-29
Chrome 68.0

@jakipatryk jakipatryk added the bug Something isn't working label Aug 30, 2018
jakipatryk added a commit that referenced this issue Sep 1, 2018
Previously, only links formatted with markdown were extraced.
Now all links (except links to images) are being fetched.

(#74) partial fix
jakipatryk added a commit that referenced this issue Sep 1, 2018
Previously, only links formatted with markdown were extraced.
Now all links (except links to images) are being fetched.

(#74) partial fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants