Refactor _broadcast_uv #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a function to handle broadcasting of `u` and `v` so as to facilitate simpler computation with the two arrays.
Simplify `_bool_cmp_cnts` a bit by making use of `_broadcast_uv`. This takes over some of the prep that `_bool_cmp_cnts` does.
Make sure that `_broadcast_uv` raises when arrays that are N-D with N>2 are provided as arguments.
Make sure that `_broadcast_uv` is behaving reasonably in the broadest sense. Namely ensuring that the shape and type of the two arrays are as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a function to handle broadcasting of
uandvso as to facilitate simpler computation with the two arrays. Use this function in_bool_cmp_cnts. Also add some basic tests for_broadcast_uv.