Run flake8 on CI #44
Merged
Run flake8 on CI #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure our fixes stay and the code stays clean going forward, we need to start running flake8 during CI. In order to make that happen, we first need to install flake8 when running CI. Hence we add a version of flake8 here that should be installable on all Python versions that we support.
Drop filler comment from cookiecutter template and add a comment above where are test suite is run.
To make sure our code quality remains ok, start running flake8 as part of our CI. If the flake8 run fails, the build will be failed as well. Should help us catch code quality errors before they creep into the codebase.
jakirkham
commented
Sep 27, 2017
| - coverage erase | ||
| - coverage run --source . setup.py test | ||
| - coverage report -m | ||
|
|
||
| # Do some basic linting of the code. | ||
| - flake8 . |
There was a problem hiding this comment.
This runs on all of our code including the library, the tests, and our setup.py file.
jakirkham
commented
Sep 27, 2017
| @@ -9,6 +9,7 @@ dependencies: | |||
| - coverage==4.0.3 | |||
| - python-coveralls==2.7.0 | |||
| - pytest==3.0.5 | |||
| - flake8==3.2.1 | |||
There was a problem hiding this comment.
Pinned to this version as packages exists on Python 2.7, 3.4, 3.5, and 3.6 from conda-forge.
|
Testing that this works as intended in PR ( #45 ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start running flake8 as part of all CI builds. Make sure flake8 is added and version fixed in our CI requirements as well. Should help make sure the code quality here remains ok (especially since we have fixed some issues 馃槈).