Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run flake8 on CI #44

Merged
merged 3 commits into from
Sep 27, 2017
Merged

Run flake8 on CI #44

merged 3 commits into from
Sep 27, 2017

Commits on Sep 27, 2017

  1. Make flake8 a CI requirement 

    To make sure our fixes stay and the code stays clean going forward, we
need to start running flake8 during CI. In order to make that happen, we
first need to install flake8 when running CI. Hence we add a version of
flake8 here that should be installable on all Python versions that we
support.
    @jakirkham
    jakirkham committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    4b2f4b9 View commit details
    Browse the repository at this point in the history

  2. Tweak comments about tests in Travis CI 

    Drop filler comment from cookiecutter template and add a comment above
where are test suite is run.
    @jakirkham
    jakirkham committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    c1db243 View commit details
    Browse the repository at this point in the history

  3. Run flake8 on CI 

    To make sure our code quality remains ok, start running flake8 as part
of our CI. If the flake8 run fails, the build will be failed as well.
Should help us catch code quality errors before they creep into the
codebase.
    @jakirkham
    jakirkham committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    e077b51 View commit details
    Browse the repository at this point in the history