Drop repeat in _broadcast_uv
#73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
force-pushed
the
drop_broadcast_repeat
branch
from
a403fdd
to
fa84f17
Compare
Having `repeat` adds a bit of overhead to the Dask. So we drop `repeat` here and simply stick with adding singleton dimensions where needed. A few things might need to get reworked as a consequence of this change, but it is worth it to reduce the overhead.
Makes some changes to the internal `_cdist_apply` function so that it can work without having `repeat` applied to dimensions. Namely drops the singleton dimensions in both broadcasted arrays and indexes only into the first dimension of each to get the point pair to compute the distance between.
jakirkham
force-pushed
the
drop_broadcast_repeat
branch
from
fa84f17
to
578f05c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops the calls to
repeatin_broadcast_uvand sticks with adding singleton dimensions where therepeatwould have been applied. Had to rework the custom metric case withcdist, but otherwise everything worked smoothly with this change. Significantly cuts down on the graph overhead and computation time throughout the distance functions.