In cdist, convert arrays to float then broadcast
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to convert arrays to float before broadcasting in `cdist` or before rechunking. Also allows rechunking to occur right before `atop`, which could be handy if `atop` needs to adjust our chunking further.
jakirkham
force-pushed
the
tweak_cdist_conv
branch
from
5d8c00b
to
76ff5d0
Compare
jakirkham
changed the title
cdist, convert arrays to float then broadcast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to convert arrays to float before broadcasting in
cdistor before rechunking. Also allows rechunking to occur right beforeatop, which could be handy ifatopneeds to adjust our chunking further.