-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUGGESTION: Version Checking - xRequires #47
Comments
Good news. It seems like there is a general consensus to name Private Functions without the Verb-Noun standard, so xRequires is cool. Have implemented a suggested solution, scoping was a bit of an issue putting private functions in a nested module. It seems like the consensus is to put them in a ps1 file and run the script via a reference in the manifest. Take a look @chelnak and see what you think before I update all the other functions that need an API check |
Nice job! What do you think about splitting the private functions out in to their own files? E.g. xRequires.ps1 There would be no functional benifit.. only consistency with the way we present the public functions. Happy either way. |
Yep, that would make sense. I'll update it and make sure all works well, but I reckon that is the way ahead |
@chelnak Updated. Let me know you are happy with it and I'll update all the functions to use it |
Code has been merged into Develop |
@jonathanmedd
I was having a play around with some PS stuff and thought it could be cool to implement the API Verison check with a declarative helper function.. e.g:
The code
The text was updated successfully, but these errors were encountered: