Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By moving to a PSScriptAnalyzerSettings file, we will no longer get the emailed errors from the PowerShell Gallery #71

Merged
merged 5 commits into from Nov 10, 2016

Conversation

jonathanmedd
Copy link
Contributor

to fix issue #70

@chelnak Could you test the Invoke-ScriptAnalyzer part the next time we run a build?

@chelnak chelnak merged commit 103fccd into development Nov 10, 2016
@chelnak
Copy link
Contributor

chelnak commented Nov 10, 2016

Ok have tested this and had to change a couple of things as the build process was not picking up the new settings:

  • PSScriptAnalyzerSettings now lives in the root directory - As per the Plaster module
  • Moved psake.build.ps1 to the root directory and renamed to build.psake.ps1 - As per the Plaster module
  • Created build.settings.ps1 and migrated some settings from build.ps1 to this

In reality a couple of items should have been done in their own branch however it is all non module impacting work

merging to development branch to continue work

jonathanmedd pushed a commit that referenced this pull request Nov 30, 2016
* Updates Get-vRACatalogItem with -ListAvailable, -Page & new pscustomobject layout

* Url encoding and pscusomobject arangement

* reworked added service, page uri encoding and pscusomobject order change

* Page support, pscusomobject change and added requestedBy and requestedFor'

* Tidied up Get-vRAService and added Get-vRAEntitledService to replace Get-vRAConsumerService

* Moved functions
=

* Created new function in to replace Get-vRAConsumerCatalogItemRequestTemplte

* Initial commit for Get-vRADeployment

* .length to .count

* .length to .count

* .length to .count

* New Get-vRAResource

* Initial commit for Get-vRAResourceAction in this branch

* Removed Get-vRADeployment

* Changed property name id to resource id

* Removed Alias

* Initial commit for Get-vRAREsourceActionRequestTemplate

* length to count

* Moved to catalog-service and cleaned up code.. adding suport for Paging

* Changes $EnvodedURI to $EscapedURI and updaed returned PSCustomObject

* Moved to catalog-service

* Moved to catalog-service

* Moved to catalog-service and cleaned code

* Changes $EncodedURI to $EscapedURI

* Changes $EncodedURI to $EscapedURI & code clean up

* Updated parametersets for actionid

* Moved to catalog-service

* Updates inputs in help

* Marks deprecated functions and removes old catalog functions

* Adds warning to deprecated functions

* Marked as deprecated

* Moves catalog-service to Functions\Public

* Moved and refactored

* functions moved to catalog-service

* Code clean up - ensure formatting and pipeline support

* Adds $VerbosePreference to invoke-vrarestmethod

* Adds support for filtering by state

* Add help text for Type parameter

* Add out-null for null response

* Updates help text to remove Consumer

* fixes issue #55

* Fixes issue #63

* Fixes issue where nested modules was being wiped when the function was invoked

* Removed Test task from Release

* Adds xRequires to functions

* Fixes issue #65

* Removes , breaking build script

* Updates documentation with catalog-service changes

* Bump Module Version to 1.4.0

* Fixes incorrect parameter for Get-vRAResourceActionRequestTemplate

* Changes ConfirmImpact="Low" to ConfirmImpact="High"

* Build improvements

* Build script improvements

* Updated documents via build.ps1

* Feature ps call stack impl (#69)

* Removes -Context and adds support for PSCallStack in xRequires

* Removes -Context

* Removes -Conext / tested function

* Fixes issue where missing tenant name causes function to fail

* Adds exclusion for Variables.json

* Catalog-Service Tests

* Update gitignore

* untracks variables.json so it is ignored

* By moving to a PSScriptAnalyzerSettings file, we will no longer get the emailed errors from the PowerShell Gallery (#71)

* By moving to a PSScriptAnalyzerSettings file, we will no longer get the emailed errors from the PowerShell Gallery

* Move to root directory

* Modify build directly

* Added Requires Version 5

* Added fix to ensure that script analyzer doesn't see variables as un assigned

* Changes the way documentation is generated

* Fixed function duplication

* Moves UpdateModuleManifest into build

* PlatyPS integration

* Set correct docs folder

* add test task to release

* Removes files that are no longer required

* Changes location

* Adds PowervRA-icon.png to repo

* Removes unneeded lines from build.ps1

* Combine build helpers in to build.psake.ps1

* Update build.settings.ps1

* updated module manifest

* Adds section to ensure index.md always reflects README.md

* Docs generated by PlatyPS

* Adds -NoMetadata switch to New-MarkdownHelp

* Rebuilt docs with no metadata at the top of the files

* Adds ValidateSet to task parameter and a help section describing the build the purpose of the script

* Updates how ScriptAnalyzer results are displayed

* Changes Severity to include Warnings and Errors - build is set to only fail when errors are detected

* Fixes issue #73 and updates associated files with correct version number

* Feature networkprofiles (#74)

* Initial draft for network-profile support

* removed hidden param

* Continuing with network profile dev.. found bugs in api

* Initial draft for network-profile support

* removed hidden param

* Continuing with network profile dev.. found bugs in api

* Migrates networkprofile commands to Functions\Public\iaas-proxy-provider

* Cleans up code

* initial commit

* Network Profile Dev

* Splitting out Network profile functions for each type of profile..

* More separation work..

* Help cleanup

* Network profile prep

* Typo in filename

* Placeholder

* Initial commit for Get-vRANetworkProfileAddressList

* Initial commit for Get-vRANetworkProfileIPRangeSummary

* Fix typo in function name

* Add xRequires -Version 7.1

* Remove IPranges support for Routed network profiles

* Updates examples

* Remove unused variable

* VerbosePreference

* Adds ShouldProcess

* Cleanup - Remove name and extra code

* tweeks

* Removal of stalte parameter sets and cleanup

* Tests template

* Re add missing }

* Updates test template

* Replaces DefaultParameterSet

* Addresses issue #75

* Updates parameter sets

* Adds network profile support to manifest

* Docs update

* Initial commit for appveyor.yml

* build settings

* Update

* adds version option

* Out-Null

* Adds build status badge

* Adds new files to gitattributes

* lowercase

* Updates help

* Updates helo

* fixes incorrect command being called

* Adds initial pester tests for network profiles

* Adds ipranges param and updates help

* Updated docs

* Limits the branches that appveyor will build

* Moved Variables.json example into the tests\data folder

* Updates variables example to support catalog-service

* Remove old variable dependencies

* Fixes issue highlighted by tests

* Removes redundant tests

* Updated Readme with support info for 7.1
@chelnak chelnak deleted the bugfix-PSScriptAnalyzerExclusions branch December 17, 2016 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants