New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy URL invalid encoding #419

Closed
bradleyayers opened this Issue Aug 10, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@bradleyayers

bradleyayers commented Aug 10, 2017

The Copy URL feature is really handy (in the favourites window), but it does not correctly URL encode usernames/passwords that contain URL reserved characters (e.g. ?). This means that the copied URL can be invalid, which means it can't be used.

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Aug 11, 2017

Owner

Thanks for catching this error. I don't know what I was thinking when I wrote that code.

Fixed in build 1756: https://eggerapps.at/postico/builds/

Owner

jakob commented Aug 11, 2017

Thanks for catching this error. I don't know what I was thinking when I wrote that code.

Fixed in build 1756: https://eggerapps.at/postico/builds/

@jakob jakob closed this Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment