Add configurable colored systems #16
Conversation
If `None` is provided a default implementation with a default color set is used.
src/schedule_graph/settings.rs
Outdated
| let is_dark = l < 0.6; | ||
|
|
||
| // Calculate text color based on bg | ||
| let text_color = style |
There was a problem hiding this comment.
This looks mostly fine but there are a few instances in which the contrast seems a little low:
Do you have an idea on how to fix this? Maybe just white or black text depending on the lightness?
There was a problem hiding this comment.
I've changed the values for light/dark text (see 5060fad). I'm not going full white/black to preserve some of the hue from the background. This should improve readability a little bit while still preserving the tint.
Although, the real issue is to find a good way to decide if I should use white or black text. Right now I'm doing it based on the background luminance (is_dark = luminance < 0.6); which is probably a naive approach, see: https://ux.stackexchange.com/q/107318
There was a problem hiding this comment.
For reference, this is how it looks like after the change:
Co-Authored-By: Jakob Hellermann <jakob.hellermann@protonmail.com>
Co-Authored-By: Jakob Hellermann <jakob.hellermann@protonmail.com>
Co-Authored-By: Jakob Hellermann <jakob.hellermann@protonmail.com>
Settings.system_styleoption, which allows to pass aSystem => Stylemapper to decide how to style a single system node.Noneis given (default behavior) a predefined set of colors are appliedFixes #13
Examples
Current color palette
I've it on a Figma file, I can create a standalone file and share it if you want.