Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mac version from https://github.com/eugene1g/phantomjs #24

Closed

Conversation

arnested
Copy link

The mac version 2.0.0 from https://github.com/ariya/phantomjs does not
work with OS X Yosemite.

An alternative build has been provided by
https://github.com/eugene1g/phantomjs.

@eugene1g has upstream hos
changes (ariya/phantomjs#12934) and they have
been applied upstream but no release is done from upstream yet.

@jakoch
Copy link
Owner

jakoch commented Dec 18, 2015

Hey Arne,

thank you for contributing and sending the patch. This is related to #12

I want to wait a few days more before merging it,
because the v2.1 release seems to be around the corner
https://groups.google.com/forum/#!topic/phantomjs-dev/vkdGvFpULNo

Preview release by Vitaliy: https://github.com/Vitallium/phantomjs/releases
For OS X: https://github.com/Vitallium/phantomjs/releases/download/2.0.1/phantomjs-2.0.1-macosx.zip

The mac version 2.0.0 from https://github.com/ariya/phantomjs does not
work with OS X Yosemite.

An alternative build has been provided by
https://github.com/eugene1g/phantomjs.

@eugene1g has upstream hos
changes (ariya/phantomjs#12934) and they have
been applied upstream but no release is done from upstream yet.
@arnested arnested force-pushed the mac-version-from-eugene1g/phantomjs branch from cd10ce3 to 3fdce1b Compare December 18, 2015 12:22
@arnested
Copy link
Author

Makes sense 👍

@jakoch
Copy link
Owner

jakoch commented Jan 25, 2016

PhantomJS v2.1.1 is out.

I've adjusted the installer to fetch the latest version and tagged a new release:
https://github.com/jakoch/phantomjs-installer/releases/tag/2.1.1

I hope its ok, that i close this PR as the situation has resolved now.
Thanks for contributing 👍
Best, Jens

@jakoch jakoch closed this Jan 25, 2016
@arnested arnested deleted the mac-version-from-eugene1g/phantomjs branch January 25, 2016 17:42
@arnested
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants