This repository has been archived by the owner on May 30, 2023. It is now read-only.
Building on OSX10.10 #12934
Closed
Building on OSX10.10 #12934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eugene1g Nice work 🤘 Maybe worth applying the upstream patch exactly as-is? |
|
Good idea. I just updated the patch to be exactly as it is upstream, and verified by recompiling on 10.10 - the binary still works as expected. |
|
👍 |
|
Looks good. I suggest squashing this into just one commit. Give me a few days to get access to Yosemite and verify the fix. |
|
Squashed! |
|
Whats going on with this? It's been open a while. |
|
Landed on the master branch and will be backported to 2.0 branch. Thanks @eugene1g! |
|
+1 |
|
|
arnested
added a commit
to arnested/phantomjs-installer
that referenced
this pull request
Dec 18, 2015
The mac version 2.0.0 from https://github.com/ariya/phantomjs does not work with OS X Yosemite. An alternative build has been provided by https://github.com/eugene1g/phantomjs. @eugene1g has upstream hos changes (ariya/phantomjs#12934) and they have been applied upstream but no release is done from upstream yet.
arnested
added a commit
to arnested/phantomjs-installer
that referenced
this pull request
Dec 18, 2015
The mac version 2.0.0 from https://github.com/ariya/phantomjs does not work with OS X Yosemite. An alternative build has been provided by https://github.com/eugene1g/phantomjs. @eugene1g has upstream hos changes (ariya/phantomjs#12934) and they have been applied upstream but no release is done from upstream yet.
arnested
added a commit
to arnested/phantomjs-installer
that referenced
this pull request
Dec 18, 2015
The mac version 2.0.0 from https://github.com/ariya/phantomjs does not work with OS X Yosemite. An alternative build has been provided by https://github.com/eugene1g/phantomjs. @eugene1g has upstream hos changes (ariya/phantomjs#12934) and they have been applied upstream but no release is done from upstream yet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick&dirty QT to allow building on Yosemite / XCode6 as per Homebrew/legacy-homebrew#29837 (comment)
This has been patched upstream with https://qt.gitorious.org/qt/qtbase/commit/70e4428b6f1c6a4bad112203f67ee7d22107616c so if Phantom QT fork will be updated then this patch will be obsolete.