Case insensitive error_get_last() check #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my system I get "stream_select(): Unable to select [4]: Interrupted system call (max_fd=4)" where "Unable" starts with capital letter, which break this check
|
I can confirm this. The “unable” → “Unable” change in the stream_select() error message seems to have happened with PHP 8. It would be great if this PR could be merged and be released as a patch release. Right now, it’s probably not possible to cleanly disconnect a synchronous Bunny client on SIGINT/SIGTERM when using PHP 8. |
mermshaus
added a commit
to mermshaus/bunny
that referenced
this pull request
Nov 30, 2022
WyriHaximus
added a commit
that referenced
this pull request
Nov 30, 2022
Add test to illustrate #125 (stream_select/interrupt issue). Also a fix
|
Thank you for filing this fix @wizu, went with the PR @mermshaus created instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my system I get "stream_select(): Unable to select [4]: Interrupted system call (max_fd=4)" where "Unable" starts with capital letter, which break this check