Add test to illustrate #125 (stream_select/interrupt issue). Also a fix #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mermshaus
changed the title
mermshaus
changed the title
WyriHaximus
approved these changes
Nov 30, 2022
| @@ -26,18 +26,21 @@ | |||
| ], | |||
| "require": { | |||
| "php": "^7.1 || ^8.0", | |||
| "ext-pcntl": "*", | |||
There was a problem hiding this comment.
This should have been added ages ago 😅 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is based on #127. Only the commits starting with “Improve code structure in tests. Add test to illustrate #125” are new.)
This PR adds a test to show the issue from #125. With some of the commits, the test intentionally fails for all PHP 8 checks. See here for example.
For good measure, I also added the smallest possible fix. This would make #125 obsolete. Hope that’s okay for everyone.
@WyriHaximus If you need more info, just get back to me in some way (e.g.
@merms@mastodon.social). I’d really like to have this merged. 🙂