-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attribute reader #32
Conversation
Amazing @icanhazstring ! Thanks for this. I'll take a look as soon as I can. |
Sure thing. Just wanted to upgrade to PHPUnit 10 and saw that open issue 😉 Will fix the code sniffer alerts later in. |
Thinking about it. Maybe we should go with a new |
Looks good!
Makes sense. We should also document the migration path.
Yep, that's the plan 👍 |
Thanks for the feedback. Yes it was pretty quickly put together 😉 Will take some time to improve the PR 👍 |
@icanhazstring sorry for the radio silence. Is this ready for another review? |
No worries. Yes go ahead 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Nice use of FP techniques 👍
Thanks. A pleasure 🙂 |
Superb work @icanhazstring. Thank you 🍺 |
Released as 3.1.0. |
Solves #25
This is a basic straight forward implementation to support attributes.
The attributes are provided by this package, as we can't rely on PHPUnit attribute parser implementation which is tied to its own attributes.