UserService works with trait GenericProfile instead of BasicProfile #477
Conversation
Reasons: 1. Scala doesn't allow to extends case class from case class. 2. Coding into interfaces is good OOP practices
|
+1 |
|
Hmm, I think this is corrupted pull request. Not all changes are pulled. |
|
@leonidv I was about to add a comment on this. I do not see any changes related to the UserService here. |
|
I +1oned the idea I haven't checked the implementation |
|
Yeah, I'm so sorry. I did refactoring but lost my changes. I'll try to make good commit today. |
Reasons: 1. Scala doesn't allow to extends case class from case class. 2. Coding into interfaces is good OOP practices
Fixed some compiles problems (checked via sbt publishLocal)
|
Fixed commits. |
|
Nice job! Any chance you could merge this, jaliss? Would love to have this in the official release! |
|
Yesterday I understood that it's not complete refactoring. Providers create BasicProfile from oauth information. Now I think how can to fix it. |
|
This pull request is ready for review. I was wrong when thought that it has some problems. By the way, it also has fix as in #481 pull request. |
|
+1 Would be very helpful! I have a complex User class |
- changed project name to SecSoc - added author (Leonid Vygovskiy) - removed java-demo module
AuthenticationException is required message string now.
|
My last commits (from 87863bf) it's not for pull request. I just not power github user and don't know how to separate pull request changes from my fork changes. |
Reasons: