Facebook fixes #605
Closed
Facebook fixes #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated GoogleProvider to use the new Google endpoints (see https://developers.google.com/+/api/auth-migration#timetable)
jaliss
reviewed
Mar 28, 2017
| case _ => | ||
| Logger.error("[securesocial] invalid response format for accessToken") | ||
| throw new AuthenticationException() | ||
| def fail(): String = { |
There was a problem hiding this comment.
this is not needed. The buildInfo method in the super class parses the json as defined in the OAuth spec.
jaliss
reviewed
Mar 28, 2017
module-code/build.sbt
Outdated
| @@ -1,8 +1,8 @@ | |||
| import play.Project._ | |||
|
|
|||
| name := "SecureSocial" | |||
| name := "InsecureSocial" | |||
There was a problem hiding this comment.
It seems you're worse than me at naming things :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is awesome, gets securesocial working with facebook api 2.3