This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
t macro properties observe locale #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 6, 2015 13:27
Tests were failing because the set of locales was correct, but wrongly ordered. Ordering the list of locales is a sensible thing to do and not terribly expensive.
Before Ember 2.1, we got the Stream function as the default export of `ember-metal/streams/stream`. After v2.1, the default export changed to a `BasicStream` class and the module exports a named `Stream` subclass.
Add `i18n.locale` to the list of dependencies for properties defined via the `t` macro.
jamesarosen
force-pushed
the
james/macro-dependencies
branch
from
dff1319
to
6373c1a
Compare
jamesarosen
pushed a commit
that referenced
this pull request
Oct 6, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localestest intermittent failures by sorting the localesStreamimporti18n.localeto the list of dependencies for properties defined via thetmacro.