Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Handles numeric (non-string) translation values #482

Merged

Conversation

patrickberkeley
Copy link
Collaborator

Closes #439

@jamesarosen jamesarosen merged commit de272de into jamesarosen:master Apr 5, 2018
@patrickberkeley patrickberkeley deleted the numbers-as-translation-values branch April 5, 2018 01:18
@patrickberkeley patrickberkeley restored the numbers-as-translation-values branch April 5, 2018 01:18
@patrickberkeley
Copy link
Collaborator Author

@jamesarosen would you mind cutting a new release?

@jamesarosen
Copy link
Owner

would you mind cutting a new release?

I just added you as a collaborator (since ember-i18n follows the "commit-bit-on-merged-PR" philosophy). I suggest a patch version.

@patrickberkeley
Copy link
Collaborator Author

Thanks! I've pushed up a new release to GitHub, but I believe it still needs to be published to NPM. I tried, but don't think I'm have permissions there.

@jamesarosen
Copy link
Owner

Whoops. I've added you as an npm maintainer.

@patrickberkeley
Copy link
Collaborator Author

Published thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants