Skip to content

Commit

Permalink
Insert upstream change which was initially omitted in the merge of bi…
Browse files Browse the repository at this point in the history 
…tcoin/bitcoin#16807 in eee64b5
  • Loading branch information
@jamesdorfman
jamesdorfman committed Jul 21, 2023
1 parent bbfdbf7 commit c52e33a
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/key_io.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ CTxDestination DecodeDestination(const std::string& str, const CChainParams& par
const std::string& hrp = for_parent ? params.ParentBech32HRP() : params.Bech32HRP();
if ((dec.encoding == bech32::Encoding::BECH32 || dec.encoding == bech32::Encoding::BECH32M) && dec.data.size() > 0) {
// Bech32 decoding
error_str = "";

if (dec.hrp != hrp) {
error_str = "Invalid prefix for Bech32 address";
Expand Down

1 comment on commit c52e33a

@delta1
Copy link

@delta1 delta1 commented on c52e33a Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change causes feature_pak.py to fail.

here's the error:

2023-07-24T09:15:46.863000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_wbzsx51l
2023-07-24T09:15:47.345000Z TestFramework (INFO): Test wallet PAK
2023-07-24T09:15:47.843000Z TestFramework (INFO): Test mempool enforcement of PAK peg-outs
{'txid': '27cc72fc29e22c463c0aeedd3e990aa0415255a85d6bd25594efc00057494c13', 'bitcoin_address': 'n1LKejAadN6hg2FrBXoU1KrwX4uK16mco9', 'bip32_counter': '0', 'bitcoin_descriptor': 'pkh(tpubD6NzVbkrYhZ4WaWSyoBvQwbpLkojyoTZPRsgXELWz3Popb3qkjcJyJUGLnL4qHHoQvao8ESaAstxYSnhyswJ76uZPStJRJCTKvosUCJZL5B/0/*)'}
2023-07-24T09:15:51.239000Z TestFramework (INFO): Test various RPC arguments
2023-07-24T09:15:51.427000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/tmp/merge-worktree/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/tmp/merge-worktree/./test/functional/feature_pak.py", line 192, in run_test
    validata = self.nodes[1].validateaddress(wpkh_stmc["bitcoin_address"])
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/merge-worktree/test/functional/test_framework/coverage.py", line 49, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/merge-worktree/test/functional/test_framework/authproxy.py", line 144, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Internal bug detected: 'is_valid_parent == error_msg_parent.empty()'
rpc/misc.cpp:92 (operator())

Please sign in to comment.