Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zadd() not working in FakeRedis #83

Closed
loisaidasam opened this issue Jun 22, 2015 · 3 comments
Closed

zadd() not working in FakeRedis #83

loisaidasam opened this issue Jun 22, 2015 · 3 comments

Comments

@loisaidasam
Copy link
Contributor

Apparently it's just adding the first key/value of **kwargs to the ZSet...

fakeredis/fakeredis.py

Lines 1300 to 1301 in e7e0069

value = list(pairs)[0]
score = list(pairs.values())[0]

Any reason?

Also not returning the number of items added...
@loisaidasam loisaidasam mentioned this issue Jun 23, 2015
Merged
jamesls added a commit that referenced this issue Jun 27, 2015
@jamesls
Merge branch 'rcrdclub-master'
b25b440 
Fixes #83.

* rcrdclub-master:
  Add test when neither args nor kwargs are added
  Proper ZADD support - fixes #83
@loisaidasam
Copy link
Contributor Author

How about uploading to PyPi?

@jamesls
Copy link
Owner

jamesls commented Jun 30, 2015

I was hoping to get a few more PR's merged into the next bug fix release, but they appear to involve more work than I expected so they'll probably have to wait for the next release. I'll get a bug fix release out in the near future.

@loisaidasam
Copy link
Contributor Author

Thanks @jamesls 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@loisaidasam @jamesls