Add type checking #166
Merged
Add type checking #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamesls I know there is a backlog of PRs, but it would be great if this could be looked at before too much other code gets changed: it touches the majority of the functions in the API and so will be nightmare to merge if it diverges too far from master. |
|
One area that isn't covered is distinguishing sets and hyperloglogs. That would take quite a bit more work, because the hyperloglog functions are mapped to set functions. |
Any operation that queries or mutates a ZSET will raise an appropriate redis.ResponseError if the key is already present with a different type. New tests are included to test this. ZINTERSTORE and ZUNIONSTORE have special treatment to allow SET types as well (undocumented feature of redis). The goal is to later extend this to other types as well.
This extends the previous commit to also raise a ResponseError when running a set operation on a non-set.
This also fixes a bug in `decr`: it would set the internal value to the integer value, without wrapping it in to_bytes.
Also fixed up the linsert implementation (with tests). It only handled "before", not "after", and it did not handle the case where the pivot is missing. The brpoplpush implementation was simplified to just call rpoplpush, since the implementations were identical.
Also fixed a bug where HINCRBY and HINCRBYFLOAT wrote the integer/float value back into the Python dict rather than the string form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends all the commands that operate on existing data of a specific type to raise a
redis.ResponseErrorif the key exists but is not of that type. This fixes #101, but is far more general than #136.The stricter checking exposed some bugs, so this PR also contains fixes (with unit tests) for #163, #164, #165.