Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getset does not to_bytes the value #163

Closed
bmerry opened this issue Nov 9, 2017 · 1 comment
Closed

getset does not to_bytes the value #163

bmerry opened this issue Nov 9, 2017 · 1 comment

Comments

@bmerry
Copy link
Collaborator

bmerry commented Nov 9, 2017

In 0.9.0, the implementation of getset doesn't pass the value through to_bytes (unlike set).

This leads to problems like the following:

>>> f = fakeredis.FakeStrictRedis()
>>> f.getset('key', 3)
>>> f.append('key', 'hello')
TypeError: unsupported operand type(s) for +=: 'int' and 'str'

I have a fix in a branch I am preparing for a PR.

@bmerry
Copy link
Collaborator Author

bmerry commented Mar 22, 2018

Fixed in 0.10.1.

@bmerry bmerry closed this as completed Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant