Function smembers returns deepcopy #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmerry
requested changes
Aug 13, 2018
added 2 commits
August 16, 2018 14:07
|
@bmerry done |
|
I think that's not the best way to test this. As far as I'm aware Python doesn't guarantee that mutating a sequence while iterating over it will lead to an exception, and even if it did, it's an indirect way of testing that the value returned by smembers is not affected by future redis operations on the set. A more direct test would be to
|
|
@bmerry It's done. The old test is also left. This is the real situation that has arisen in me. |
|
Thanks. |
bmerry
approved these changes
Aug 17, 2018
| @@ -1488,6 +1488,12 @@ def test_sismember_wrong_type(self): | |||
| def test_smembers(self): | |||
| self.assertEqual(self.redis.smembers('foo'), set()) | |||
|
|
|||
| def test_smembers_copy(self): | |||
| self.redis.sadd('foo', 'member1') | |||
| set = self.redis.smembers('foo') | |||
There was a problem hiding this comment.
Can you call this something other than set, since that's a builtin type.
| self.redis.sadd('foo', 'member1') | ||
| set = self.redis.smembers('foo') | ||
| self.redis.sadd('foo', 'member2') | ||
| self.assertNotEqual(set, self.redis.smembers('foo')) |
There was a problem hiding this comment.
Maybe rather check that self.assertEqual(value, set(['member1'])) since that's a more specific test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.