Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function smembers returns deepcopy #202

Merged
merged 4 commits into from
Aug 17, 2018
Merged

Function smembers returns deepcopy #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
720671d
Function smembers returns deepcopy
Aug 12, 2018
10964ba
Add tests
Aug 16, 2018
b38eeb0
Remove error
Aug 16, 2018
2b02f98
Add test smembers copy
Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion fakeredis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,7 +1362,7 @@ def sismember(self, name, value):

def smembers(self, name):
"Return all members of the set ``name``"
return self._get_set(name)
return self._get_set(name).copy()

@_remove_empty
def smove(self, src, dst, value):
Expand Down
11 changes: 11 additions & 0 deletions test_fakeredis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,11 +1488,22 @@ def test_sismember_wrong_type(self):
def test_smembers(self):
self.assertEqual(self.redis.smembers('foo'), set())

def test_smembers_copy(self):
self.redis.sadd('foo', 'member1')
set = self.redis.smembers('foo')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you call this something other than set, since that's a builtin type.

self.redis.sadd('foo', 'member2')
self.assertNotEqual(set, self.redis.smembers('foo'))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rather check that self.assertEqual(value, set(['member1'])) since that's a more specific test.


def test_smembers_wrong_type(self):
self.redis.zadd('foo', 1, 'member')
with self.assertRaises(redis.ResponseError):
self.redis.smembers('foo')

def test_smembers_runtime_error(self):
self.redis.sadd('foo', 'member1', 'member2')
for member in self.redis.smembers('foo'):
self.redis.srem('foo', member)

def test_smove(self):
self.redis.sadd('foo', 'member1')
self.redis.sadd('foo', 'member2')
Expand Down