Implement SET with KEEPTTL #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgetka
commented
Aug 14, 2020
| else: | ||
| raise SimpleError(SYNTAX_ERROR_MSG) | ||
| if (xx and nx) or (px is not None and ex is not None): | ||
| if (xx and nx) or ((px is not None) + (ex is not None) + keepttl > 1): |
There was a problem hiding this comment.
SET command documentation suggests that KEEPTTL option can be set next to PX or EX options, but in reality redis denies such requests. This behavior seems reasonable so I believe this is an error in the documentation and thus I enforce the actual (not the documented) behavior on the case of conflicting expiration options.
|
Thanks, good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to
KEEPTTLflag in theSETcommand which become available inredis-py3.5.0.