updated base.py. (winfunc added in logfbank) #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously I was using fbank for feature extraction. Then when I found that when I used log on the Fbank the accuracy of the model was better. But I was using hamming frame on windows for feature extraction, because of this I was taking log after implementing fbank. So it would be better if we have a choice to apply window function while using logfbank function as well.
|
Thanks mr yamraj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I was using fbank for feature extraction. Then when I found that when I used log on the Fbank the accuracy of the model was better. But I was using hamming frame on windows for feature extraction, because of this I was taking log after implementing fbank. So it would be better if we have a choice to apply window function while using logfbank function as well.