Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a custom exception for invalid driver error | close #348 #347

Closed
wants to merge 1 commit into from
Closed

Create a custom exception for invalid driver error | close #348 #347

wants to merge 1 commit into from

Conversation

RaulShinaede
Copy link

Thank you for your contribution!
Before submitting this PR, please consider:

  • If you are fixing something other than a typo, please always create an issue first. Otherwise, your PR will probably be rejected.
  • You have added unit tests which (a) pass and (b) sufficiently cover your changes

@RaulShinaede RaulShinaede changed the title Create a custom exception for invalid driver error Create a custom exception for invalid driver error #348 Sep 16, 2023
@RaulShinaede RaulShinaede changed the title Create a custom exception for invalid driver error #348 Create a custom exception for invalid driver error | close #348 Sep 16, 2023
@jamesmh
Copy link
Owner

jamesmh commented Sep 16, 2023

Thanks! Could you add at least a couple of tests against the AddMailer method?

  1. Passing test against one of the valid drivers
  2. Test again a missing driver and validation the proper exception is thrown

👌

@jamesmh jamesmh self-requested a review September 16, 2023 22:06
@RaulShinaede RaulShinaede closed this by deleting the head repository Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants