This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Remove empty vertical spacing between items on PodcastDirectoryPage #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1
There was a lot of vertical spacing between items on PodcastDirectoryPage, noticeable on smaller devices Xiaomi Redmi 3s, Xperia M, iPhone SE.
Screenshots for Issue 1
![screenshot 76](https://user-images.githubusercontent.com/14297705/58638168-c7b94000-8311-11e9-8be7-96dfb6b950e5.png)
![Screenshot_Hanselman_20190526-195254](https://user-images.githubusercontent.com/14297705/58638337-2e3e5e00-8312-11e9-80a7-740bb4d435f5.png)
Fix for Issue 1:
Set the height of row holding the artwork to 200, as the images themselves have a res of 200x200.
(Another related) issue 2
There was also the case that if the text was too long, then it wrapped on to the next line and created irregular item size.
Screenshot for Issue 2
![screenshot 79](https://user-images.githubusercontent.com/14297705/58638448-7a899e00-8312-11e9-918d-2e938cdd55fb.png)
![screenshot 82](https://user-images.githubusercontent.com/14297705/58638452-7b223480-8312-11e9-9bc4-3f154a4eb59f.png)
Fix for Issue 2:
Set the
LineBreakMode
property toTailTruncation
for the label holding the Title.** Final Result With Fixes **
![Screenshot_Hanselman_20190526-200846](https://user-images.githubusercontent.com/14297705/58638910-7d38c300-8313-11e9-8321-ef03ac254b70.png)
![screenshot 80](https://user-images.githubusercontent.com/14297705/58638928-86c22b00-8313-11e9-85bf-bf0f529a1361.png)
@jamesmontemagno Please suggest if these changes are fine or we need to discuss more ? 😄 🐒