Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Remove empty vertical spacing between items on PodcastDirectoryPage #122

Conversation

manutdkid77
Copy link
Contributor

Issue 1
There was a lot of vertical spacing between items on PodcastDirectoryPage, noticeable on smaller devices Xiaomi Redmi 3s, Xperia M, iPhone SE.

Screenshots for Issue 1
screenshot 76
Screenshot_Hanselman_20190526-195254

Fix for Issue 1:
Set the height of row holding the artwork to 200, as the images themselves have a res of 200x200.


(Another related) issue 2
There was also the case that if the text was too long, then it wrapped on to the next line and created irregular item size.

Screenshot for Issue 2
screenshot 79
screenshot 82

Fix for Issue 2:
Set the LineBreakMode property to TailTruncation for the label holding the Title.

** Final Result With Fixes **
Screenshot_Hanselman_20190526-200846
screenshot 80

@jamesmontemagno Please suggest if these changes are fine or we need to discuss more ? 😄 🐒

@jamesmontemagno
Copy link
Owner

Hmmm the podcast art should a perfect Square that is my only comment there.

@manutdkid77
Copy link
Contributor Author

@jamesmontemagno I've been working on creating a UI similar to AntennaPod and PocketCasts apps which I plan to use for the PodcastsDirectory page. I've created a sample repo for it.

@jamesmontemagno
Copy link
Owner

Changed a bunch how this works, so no longer needed, but thanks for the PR :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants