Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in app billing 4 for android #399

Merged
merged 6 commits into from Aug 14, 2021
Merged

Add in app billing 4 for android #399

merged 6 commits into from Aug 14, 2021

Conversation

jamesmontemagno
Copy link
Owner

Please take a moment to fill out the following:

Fixes # .

Changes Proposed in this pull request:

@philtomblin
Copy link

I've not had as much time this weekend as I had planned so haven't completed integrating this into my app yet. Only feedback so far is that you can remove IInAppBillingVerifyPurchase.shared.cs, since it should have been removed from everywhere else. I'll let you know when I've finished the refactoring...

@philtomblin
Copy link

@jamesmontemagno I can confirm this now works perfectly for iOS. I need to implement Android verification in my backend before I can check the app logic there.

@CartBlanche
Copy link

I'm assuming everyone received the Google emails this week about upgrading to v 4. Any rough idea when this PR is likely to be merged?

@philtomblin
Copy link

It's obviously in James' hands but, FWIW, I'm working on my Android app at the moment so am hoping to complete my own testing in the next week or so. This seems pretty solid so worth trying out nuget v5.0.1 beta, which corresponds to this, as far as I know.

@CartBlanche
Copy link

@philtomblin I miss wrote, I meant merged into main and therefore made stable. I am already using v5.0.1 beta but need to double check that it is using v4 under the hood.

@jamesmontemagno
Copy link
Owner Author

@CartBlanche so the email is that you need v3 or v4. We have used v3 for since v4.0 of the nuget

@jamesmontemagno
Copy link
Owner Author

v5.0 used v4 of billing :) i like how the numbers don't align at all.

So if you are using v4.0 of the nuget you are fine

@jamesmontemagno jamesmontemagno merged commit 17af6e5 into master Aug 14, 2021
@philtomblin
Copy link

@jamesmontemagno For completeness, I can confirm I have this working perfectly for Android subscriptions too. Thanks again for getting this sorted out so promptly!

@jamesmontemagno jamesmontemagno deleted the androidbilling4 branch April 12, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants