-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect results for Windows Terminal #7
Comments
PR Welcome. |
@jamestalmage it is not possible to properly implement it until microsoft/terminal#1040 is completed. |
I was finding ways to know the version number as you said. One way I thought of was to execute |
Right now, this is the best way I could find to do it. |
But we also want the version of Windows Terminal, don't we?
…On Fri, 8 Jan 2021, 06:48 Richie Bendall, ***@***.***> wrote:
Right now, this is the best way I could find to do it
<https://github.com/Richienb/is-windows-terminal>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB55PTWKYDQT6YCNBB35MMTSYZMOFANCNFSM4T4P2A7Q>
.
|
@abhijit-hota Perhaps we can get the version from the Windows Store package. |
Starting with v1.4, Windows Terminal supports embedded hyperlinks.
However,
supports-hyperlinks
returnsfalse
for this terminal.As a workaround, I set the environment variable
FORCE_HYPERLINK
, and everything started working fine.It happens because there is a piece of code that disables hyperlink support everywhere on Windows (which is not correct):
It is possible to understand that we're running in Windows Terminal by checking
env.WT_SESSION
existence; however, it is not so easy to get the actual version of the terminal. See microsoft/terminal#1040 for more details.The text was updated successfully, but these errors were encountered: