Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Theme Support #150

Merged
merged 17 commits into from
Jan 15, 2022
Merged

Add Theme Support #150

merged 17 commits into from
Jan 15, 2022

Conversation

jamesvandyne
Copy link
Owner

Add theming support per #83

James Van Dyne added 4 commits January 1, 2022 08:11
This commit changes specific color references in public html templates to
generic names for easier theming. e.g. border-negroni-900 -> border-secondary.
@jamesvandyne jamesvandyne self-assigned this Dec 31, 2021
@@ -16,23 +16,23 @@
<link href="{{ absolute_url }}{% url 'indieweb:indieauth_token' %}" rel="token_endpoint"/>
<link href="{{ absolute_url }}{% url 'indieweb:micropub' %}" rel="micropub"/>
<link href="{{ absolute_url }}{% url 'micropub_media' %}" rel="micropub_media"/>
<link href="{% static 'tailwind/style.css' %}?=1" rel="stylesheet">
<link href="{% static 'themes/platinum/style.css' %}" rel="stylesheet">
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Make this reference a non-hardcoded theme.



.selected {
@apply border-r-4 bg-secondary;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently unable to generate css because bg-secondary is giving me errors like

The bg-secondary class does not exist. If bg-secondary is a custom class, make sure it is defined within a @layer directive.

This is true for any color, even included colors. This may be a bug in tailwind as other people are having similar issues tailwindlabs/tailwindcss#6818. I haven't tried older versions of tailwind, yet.

@@ -0,0 +1,24 @@
module.exports = {
content: [
'../../../apps/templates/base_public.html',
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that this is content glob is relative to the tailwind.config.js. Ideally this should be extended from a "default theme" config, so new child themes wouldn't need to re-define content each time, or they could just extend it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant