-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Theme Support #150
Add Theme Support #150
Conversation
This commit changes specific color references in public html templates to generic names for easier theming. e.g. border-negroni-900 -> border-secondary.
apps/templates/base_public.html
Outdated
@@ -16,23 +16,23 @@ | |||
<link href="{{ absolute_url }}{% url 'indieweb:indieauth_token' %}" rel="token_endpoint"/> | |||
<link href="{{ absolute_url }}{% url 'indieweb:micropub' %}" rel="micropub"/> | |||
<link href="{{ absolute_url }}{% url 'micropub_media' %}" rel="micropub_media"/> | |||
<link href="{% static 'tailwind/style.css' %}?=1" rel="stylesheet"> | |||
<link href="{% static 'themes/platinum/style.css' %}" rel="stylesheet"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Make this reference a non-hardcoded theme.
front/themes/platinum/style.css
Outdated
|
||
|
||
.selected { | ||
@apply border-r-4 bg-secondary; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently unable to generate css because bg-secondary is giving me errors like
The
bg-secondary
class does not exist. Ifbg-secondary
is a custom class, make sure it is defined within a@layer
directive.
This is true for any color, even included colors. This may be a bug in tailwind as other people are having similar issues tailwindlabs/tailwindcss#6818. I haven't tried older versions of tailwind, yet.
@@ -0,0 +1,24 @@ | |||
module.exports = { | |||
content: [ | |||
'../../../apps/templates/base_public.html', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming that this is content glob is relative to the tailwind.config.js. Ideally this should be extended from a "default theme" config, so new child themes wouldn't need to re-define content each time, or they could just extend it.
Add theming support per #83